Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement --no-diffs CLI Option #195

Merged
merged 1 commit into from Apr 19, 2024

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Apr 19, 2024

replicated the rector implementation of --no-diffs 1:1

closes #191

$ time php ../easy-coding-standard/bin/ecs check

**... snip walls of text of diff**
                                                                                                                        
 [WARNING] 885 errors are fixable! Just add "--fix" to console command and rerun to apply.                              

real    0m50.121s
user    0m0.000s
sys     0m0.000s

$ time php ../easy-coding-standard/bin/ecs check --no-diffs
 890/890 [============================] 100%

                                                                                                                        
 [WARNING] 885 errors are fixable! Just add "--fix" to console command and rerun to apply.                              


real    0m42.911s
user    0m0.015s
sys     0m0.000s
`` 

@TomasVotruba TomasVotruba merged commit 1933073 into easy-coding-standard:main Apr 19, 2024
7 checks passed
@TomasVotruba
Copy link
Contributor

Thank you 👍

@staabm staabm deleted the nodiffs branch April 19, 2024 14:05
@staabm
Copy link
Contributor Author

staabm commented Apr 19, 2024

thank you guys for review and merging. I don't plan any more changes as all low hanging fruits have been adressed.

would be great to see a release with the recent changes :-)

@samsonasik
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

diff rendering is slow
3 participants