Remove repeated calls to EasyCodingStandardStyle->isDebug()
#194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsonasik
reviewed
Apr 19, 2024
| @@ -44,6 +46,7 @@ public function __construct( | |||
| array $fixers | |||
| ) { | |||
| $this->fixers = $this->sortFixers($fixers); | |||
| $this->isDebug = $easyCodingStandardStyle->isDebug(); | |||
There was a problem hiding this comment.
is this need to be applied in EasyCodingStandardApplication and File object as well?
There was a problem hiding this comment.
I did it only here to keep the PR minimal. isDebug() is not per se slow/hungry, but in this special case which is called very frequently. other occurences do not show up in profilling.
samsonasik
approved these changes
Apr 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
repeating
isDebugcalls are showing up in the top 6 of memory consuming methods, measured by blackfire:(because this method is called from
processTokensByFixerwhich is the most called function in the whole project)