Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buffer pre-fill #122

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Buffer pre-fill #122

wants to merge 4 commits into from

Conversation

h3ndrik
Copy link
Contributor

@h3ndrik h3ndrik commented Aug 28, 2018

allow the user to pre-fill the AudioFileSourceBuffer before calling out.begin()

@h3ndrik
Copy link
Contributor Author

h3ndrik commented Aug 30, 2018

i'm sorry, there is still some error.
with this patch applied, the decoder doesn't recover from decoding errors any more.
i can only imagine this is because before 'filled' was still false after the non-blocking fill() call and now length can become >0

@h3ndrik
Copy link
Contributor Author

h3ndrik commented Aug 31, 2018

reverted that change and set filled after pre-buffering.

There is already a comment in the code about forcing a complete refill:

// We're out of buffered data, need to force a complete refill. Thanks, @armSeb

That's probably why we don't only look at length;-) Sorry.

EDIT: Not sure if this is a real problem. I'm having the same problems after reverting that commit.
There is something wrong with the mad mp3 decoder losing sync and then not syncing ever again. Happens on some (most) of the internet streams and i'm not sure why it can't sync again.

EDIT2: Problem gone after changing ...ICY... to AudioFileSourceHTTPStream. I'll open another bug report for that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant