Adjusted tests and added improved logging

eandersson · Oct 22, 2021 · f61784d · f61784d
1 parent 05771cb
commit f61784d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/amqpstorm/io.py b/amqpstorm/io.py
@@ -282,7 +282,10 @@ def _receive(self):
             if why.args[0] not in (EWOULDBLOCK, EAGAIN):
                 self._exceptions.append(AMQPConnectionError(why))
                 if self._running.is_set():
-                    LOGGER.warning("Stopping inbound thread due to %s", why)
+                    LOGGER.warning(
+                        "Stopping inbound thread due to %s", why,
+                        exc_info=True
+                    )
                 self._running.clear()
         return data_in
 

diff --git a/amqpstorm/tests/utility.py b/amqpstorm/tests/utility.py
@@ -114,7 +114,7 @@ def __init__(self, name='FakeFrame'):
 
     def __iter__(self):
         for attribute in ['_data_1']:
-            yield (attribute[1::], getattr(self, attribute))
+            yield attribute[1::], getattr(self, attribute)
 
 
 class FakeSession(object):
@@ -197,7 +197,6 @@ def get_last_log(self):
     def tearDown(self):
         if self.validate_logging:
             try:
-                self.assertFalse(self.logging_handler.messages['warning'])
                 self.assertFalse(self.logging_handler.messages['error'])
                 self.assertFalse(self.logging_handler.messages['critical'])
             finally: