Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tab_debug: fixed labels with new array of labels #1

Closed
wants to merge 4 commits into from
Closed

tab_debug: fixed labels with new array of labels #1

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
7e2d3b7
tab_debug: fixed labels with new array of labels
Lyreplus Dec 4, 2023
bab9d95
tab_debug: moved update functions from steering to tab debug, added C…
Lyreplus Dec 9, 2023
b09f109
tab_debug: updated update functions, fixed with steering
Lyreplus Dec 11, 2023
95d4fb2
feat: update last state only if message differs
RickyBenevelli Mar 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 2 additions & 3 deletions Core/UI/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,15 +2,14 @@
build/

# Ignore all dot folders, with below exceptions
.*/

*.log

# VSCode
!.vscode/
!.vscode/*

logs/**

#CLion
.idea/

.vscode/settings.json
172 changes: 0 additions & 172 deletions Core/UI/steering/racing_tabs/tab_debug.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,11 +22,6 @@ lv_obj_t *das_errors_panel;

extern racing_tab_t current_racing_tab;

primary_hv_errors_converted_t hv_errors_last_state = {0};
primary_hv_feedback_status_converted_t hv_feedback_status_last_state = {0};
primary_das_errors_converted_t das_errors_last_state = {0};
primary_lv_errors_converted_t lv_errors_last_state = {0};

lv_obj_t *cell_create(lv_obj_t *parent, const char *text, uint8_t pos_col,
uint8_t pos_row, lv_style_t *style) {
lv_obj_t *cell = lv_obj_create(parent);
Expand Down Expand Up @@ -499,171 +494,4 @@ void change_errors_view(bool dir_left) {

#endif

void set_label_color_hv_feedbacks(int label, int i) {
// PRIMARY_HV_FEEDBACK_STATUS_FEEDBACK_BMS_COCKPIT_FEEDBACK_STATE_LOW_CHOICE
// it's better to use the enum canlib, but we use 0 or 1 or 2 for demplicity
Lyreplus marked this conversation as resolved.
Show resolved Hide resolved
// sake. If canlib specs will change, then we need to change also this code
if (label == 0 || label == 2) {
lv_obj_set_style_border_color(
hv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
hv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
} else {
if (label == 1) {
lv_obj_set_style_border_color(
hv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
hv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
} else {
lv_obj_set_style_border_color(
hv_errors[i], lv_color_hex(COLOR_YELLOW_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
hv_errors[i], lv_color_hex(COLOR_YELLOW_STATUS_HEX), LV_PART_MAIN);
}
}
}

void hv_feedbacks_status_update() {
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_implausibility_detected, 0);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_imd_cockpit, 1);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_tsal_green_fault_latched, 2);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_bms_cockpit, 3);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_ext_latched, 4);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_tsal_green, 5);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_ts_over_60v_status, 6);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_airn_status, 7);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_airp_status, 8);
set_label_color_hv_feedbacks(hv_feedback_status_last_state.feedback_airp_gate,
9);
set_label_color_hv_feedbacks(hv_feedback_status_last_state.feedback_airn_gate,
10);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_precharge_status, 11);
set_label_color_hv_feedbacks(
hv_feedback_status_last_state.feedback_tsp_over_60v_status, 12);
set_label_color_hv_feedbacks(hv_feedback_status_last_state.feedback_imd_fault,
13);
set_label_color_hv_feedbacks(hv_feedback_status_last_state.feedback_check_mux,
14);
set_label_color_hv_feedbacks(hv_feedback_status_last_state.feedback_sd_end,
15);
set_label_color_hv_feedbacks(hv_feedback_status_last_state.feedback_sd_out,
16);
set_label_color_hv_feedbacks(hv_feedback_status_last_state.feedback_sd_in,
17);
set_label_color_hv_feedbacks(hv_feedback_status_last_state.feedback_sd_bms,
18);
set_label_color_hv_feedbacks(hv_feedback_status_last_state.feedback_sd_imd,
19);
}

void set_label_color_hv_errors(int label, int i) {
if (label) {
lv_obj_set_style_border_color(
hv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(hv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX),
LV_PART_MAIN);
} else {
lv_obj_set_style_border_color(
hv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
hv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
}
}

void hv_errors_update() {
// could be used enum_to_string but same outcome with still same number of
// lines
set_label_color_hv_errors(hv_errors_last_state.errors_cell_low_voltage, 0);
set_label_color_hv_errors(hv_errors_last_state.errors_cell_under_voltage, 1);
set_label_color_hv_errors(hv_errors_last_state.errors_cell_over_voltage, 2);
set_label_color_hv_errors(hv_errors_last_state.errors_cell_high_temperature,
3);
set_label_color_hv_errors(hv_errors_last_state.errors_cell_over_temperature,
4);
set_label_color_hv_errors(hv_errors_last_state.errors_over_current, 5);
set_label_color_hv_errors(hv_errors_last_state.errors_can, 6);
set_label_color_hv_errors(hv_errors_last_state.errors_int_voltage_mismatch,
7);
set_label_color_hv_errors(hv_errors_last_state.errors_cellboard_comm, 8);
set_label_color_hv_errors(hv_errors_last_state.errors_cellboard_internal, 9);
set_label_color_hv_errors(hv_errors_last_state.errors_connector_disconnected,
10);
set_label_color_hv_errors(hv_errors_last_state.errors_fans_disconnected, 11);
set_label_color_hv_errors(hv_errors_last_state.errors_feedback, 12);
set_label_color_hv_errors(hv_errors_last_state.errors_feedback_circuitry, 13);
set_label_color_hv_errors(hv_errors_last_state.errors_eeprom_comm, 14);
set_label_color_hv_errors(hv_errors_last_state.errors_eeprom_write, 15);
}

void set_label_color_das_errors(bool label, int i) {
if (label) {
lv_obj_set_style_border_color(
das_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(das_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX),
LV_PART_MAIN);
} else {
lv_obj_set_style_border_color(
das_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
das_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
}
}

void das_errors_update() {
set_label_color_das_errors(das_errors_last_state.das_error_pedal_adc, 0);
set_label_color_das_errors(
das_errors_last_state.das_error_pedal_implausibility, 1);
set_label_color_das_errors(das_errors_last_state.das_error_imu_tout, 2);
set_label_color_das_errors(das_errors_last_state.das_error_irts_tout, 3);
set_label_color_das_errors(das_errors_last_state.das_error_ts_tout, 4);
set_label_color_das_errors(das_errors_last_state.das_error_invl_tout, 5);
set_label_color_das_errors(das_errors_last_state.das_error_invr_tout, 6);
set_label_color_das_errors(das_errors_last_state.das_error_steer_tout, 7);
set_label_color_das_errors(das_errors_last_state.das_error_fsm, 8);
}

void set_label_color_lv_errors(bool label, int i) {
if (label) {
lv_obj_set_style_border_color(
lv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(lv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX),
LV_PART_MAIN);
} else {
lv_obj_set_style_border_color(
lv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
lv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
}
}

void lv_errors_update() {
set_label_color_lv_errors(lv_errors_last_state.errors_cell_undervoltage, 0);
set_label_color_lv_errors(lv_errors_last_state.errors_cell_overvoltage, 1);
set_label_color_lv_errors(lv_errors_last_state.errors_battery_open_wire, 2);
set_label_color_lv_errors(lv_errors_last_state.errors_can, 3);
set_label_color_lv_errors(lv_errors_last_state.errors_spi, 4);
set_label_color_lv_errors(lv_errors_last_state.errors_over_current, 5);
set_label_color_lv_errors(lv_errors_last_state.errors_cell_under_temperature,
6);
set_label_color_lv_errors(lv_errors_last_state.errors_cell_over_temperature,
7);
set_label_color_lv_errors(lv_errors_last_state.errors_relay, 8);
set_label_color_lv_errors(lv_errors_last_state.errors_bms_monitor, 9);
set_label_color_lv_errors(lv_errors_last_state.errors_voltages_not_ready, 10);
set_label_color_lv_errors(lv_errors_last_state.errors_mcp23017, 11);
set_label_color_lv_errors(lv_errors_last_state.errors_radiator, 12);
set_label_color_lv_errors(lv_errors_last_state.errors_fan, 13);
set_label_color_lv_errors(lv_errors_last_state.errors_pump, 14);
set_label_color_lv_errors(lv_errors_last_state.errors_adc_init, 15);
set_label_color_lv_errors(lv_errors_last_state.errors_mux, 16);
}
5 changes: 5 additions & 0 deletions Core/UI/steering/racing_tabs/tab_debug.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,11 @@ typedef enum {
TAB_LV_ERRORS
} ErrorTabID;

extern lv_obj_t *hv_feedbacks_status[20];
Lyreplus marked this conversation as resolved.
Show resolved Hide resolved
extern lv_obj_t *hv_errors[16];
extern lv_obj_t *das_errors[9];
extern lv_obj_t *lv_errors[17];

void tab_debug_create(lv_obj_t *parent);
void init_debug_styles(void);

Expand Down
174 changes: 174 additions & 0 deletions Core/UI/steering/steering.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -614,3 +614,177 @@ void handle_ptt_message(void) {
ecu_ack = true;
}
}

Lyreplus marked this conversation as resolved.
Show resolved Hide resolved
void set_label_color_hv_feedbacks(int label, int i) {
Lyreplus marked this conversation as resolved.
Show resolved Hide resolved
// PRIMARY_HV_FEEDBACK_STATUS_FEEDBACK_BMS_COCKPIT_FEEDBACK_STATE_LOW_CHOICE
// it's better to use the enum canlib, but we use 0 or 1 or 2 for demplicity
// sake. If canlib specs will change, then we need to change also this code
if (label == 0 || label == 2) {
lv_obj_set_style_border_color(
hv_feedbacks_status[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
hv_feedbacks_status[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
} else {
if (label == 1) {
lv_obj_set_style_border_color(
hv_feedbacks_status[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
hv_feedbacks_status[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
} else {
lv_obj_set_style_border_color(
hv_feedbacks_status[i], lv_color_hex(COLOR_YELLOW_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
hv_feedbacks_status[i], lv_color_hex(COLOR_YELLOW_STATUS_HEX), LV_PART_MAIN);
}
}
}

void hv_feedbacks_status_update() {
GET_LAST_STATE(primary, hv_feedback_status, PRIMARY, HV_FEEDBACK_STATUS);

set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_implausibility_detected, 0);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_imd_cockpit, 1);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_tsal_green_fault_latched, 2);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_bms_cockpit, 3);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_ext_latched, 4);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_tsal_green, 5);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_ts_over_60v_status, 6);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_airn_status, 7);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_airp_status, 8);
set_label_color_hv_feedbacks(primary_hv_feedback_status_last_state->feedback_airp_gate,
9);
set_label_color_hv_feedbacks(primary_hv_feedback_status_last_state->feedback_airn_gate,
10);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_precharge_status, 11);
set_label_color_hv_feedbacks(
primary_hv_feedback_status_last_state->feedback_tsp_over_60v_status, 12);
set_label_color_hv_feedbacks(primary_hv_feedback_status_last_state->feedback_imd_fault,
13);
set_label_color_hv_feedbacks(primary_hv_feedback_status_last_state->feedback_check_mux,
14);
set_label_color_hv_feedbacks(primary_hv_feedback_status_last_state->feedback_sd_end,
15);
set_label_color_hv_feedbacks(primary_hv_feedback_status_last_state->feedback_sd_out,
16);
set_label_color_hv_feedbacks(primary_hv_feedback_status_last_state->feedback_sd_in,
17);
set_label_color_hv_feedbacks(primary_hv_feedback_status_last_state->feedback_sd_bms,
18);
set_label_color_hv_feedbacks(primary_hv_feedback_status_last_state->feedback_sd_imd,
19);
}

void set_label_color_hv_errors(int label, int i) {
if (label) {
lv_obj_set_style_border_color(
hv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(hv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX),
LV_PART_MAIN);
} else {
lv_obj_set_style_border_color(
hv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
hv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
}
}

void hv_errors_update() {
// could be used enum_to_string but same outcome with still same number of
// lines
GET_LAST_STATE(primary, hv_errors, PRIMARY, HV_ERRORS);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_cell_low_voltage, 0);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_cell_under_voltage, 1);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_cell_over_voltage, 2);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_cell_high_temperature,
3);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_cell_over_temperature,
4);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_over_current, 5);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_can, 6);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_int_voltage_mismatch,
7);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_cellboard_comm, 8);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_cellboard_internal, 9);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_connector_disconnected,
10);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_fans_disconnected, 11);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_feedback, 12);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_feedback_circuitry, 13);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_eeprom_comm, 14);
set_label_color_hv_errors(primary_hv_errors_last_state->errors_eeprom_write, 15);
}

void set_label_color_das_errors(bool label, int i) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

set_label_color_das_errors, set_label_color_hv_errors, set_label_color_lv_errors are all the same. Also set_label_color_hv_feedbacks is similar. Try to write only one function to to all this. The simpler is the function, the better.

if (label) {
lv_obj_set_style_border_color(
das_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(das_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX),
LV_PART_MAIN);
} else {
lv_obj_set_style_border_color(
das_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
das_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
}
}

void das_errors_update() {
GET_LAST_STATE(primary, das_errors, PRIMARY, DAS_ERRORS);
set_label_color_das_errors(primary_das_errors_last_state->das_error_pedal_adc, 0);
set_label_color_das_errors(
primary_das_errors_last_state->das_error_pedal_implausibility, 1);
set_label_color_das_errors(primary_das_errors_last_state->das_error_imu_tout, 2);
set_label_color_das_errors(primary_das_errors_last_state->das_error_irts_tout, 3);
set_label_color_das_errors(primary_das_errors_last_state->das_error_ts_tout, 4);
set_label_color_das_errors(primary_das_errors_last_state->das_error_invl_tout, 5);
set_label_color_das_errors(primary_das_errors_last_state->das_error_invr_tout, 6);
set_label_color_das_errors(primary_das_errors_last_state->das_error_steer_tout, 7);
set_label_color_das_errors(primary_das_errors_last_state->das_error_fsm, 8);
}

void set_label_color_lv_errors(bool label, int i) {
if (label) {
lv_obj_set_style_border_color(
lv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(lv_errors[i], lv_color_hex(COLOR_RED_STATUS_HEX),
LV_PART_MAIN);
} else {
lv_obj_set_style_border_color(
lv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
lv_obj_set_style_bg_color(
lv_errors[i], lv_color_hex(COLOR_GREEN_STATUS_HEX), LV_PART_MAIN);
}
}

void lv_errors_update() {
GET_LAST_STATE(primary, lv_errors, PRIMARY, LV_ERRORS);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_cell_undervoltage, 0);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_cell_overvoltage, 1);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_battery_open_wire, 2);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_can, 3);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_spi, 4);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_over_current, 5);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_cell_under_temperature,
6);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_cell_over_temperature,
7);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_relay, 8);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_bms_monitor, 9);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_voltages_not_ready, 10);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_mcp23017, 11);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_radiator, 12);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_fan, 13);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_pump, 14);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_adc_init, 15);
set_label_color_lv_errors(primary_lv_errors_last_state->errors_mux, 16);
}