fix: use sum of cells voltage in voltage mistmatch error check

eagletrt · Dec 13, 2023 · 8d0a7e8 · 8d0a7e8
1 parent df77bc1
commit 8d0a7e8
Show file tree

Hide file tree

Showing 2 changed files with 2,137 additions and 2,143 deletions.
diff --git a/mainboard/Src/pack/internal_voltage.c b/mainboard/Src/pack/internal_voltage.c
@@ -75,11 +75,11 @@ bool internal_voltage_is_precharge_complete() {
     float tsp = CONVERT_VALUE_TO_INTERNAL_VOLTAGE(internal_voltages.tsp);
     float target;
     if (is_handcart_connected)
-        target = CONVERT_VALUE_TO_INTERNAL_VOLTAGE(internal_voltages.bat) * INTERNAL_VOLTAGE_PRECHARGE_HANDCART_THRESHOLD;
-        // target = CONVERT_VALUE_TO_VOLTAGE(cell_voltage_get_sum()) * INTERNAL_VOLTAGE_PRECHARGE_HANDCART_THRESHOLD;
+        // target = CONVERT_VALUE_TO_INTERNAL_VOLTAGE(internal_voltages.bat) * INTERNAL_VOLTAGE_PRECHARGE_HANDCART_THRESHOLD;
+        target = CONVERT_VALUE_TO_VOLTAGE(cell_voltage_get_sum()) * INTERNAL_VOLTAGE_PRECHARGE_HANDCART_THRESHOLD;
     else
-        target = CONVERT_VALUE_TO_INTERNAL_VOLTAGE(internal_voltages.bat) * INTERNAL_VOLTAGE_PRECHARGE_THRESHOLD;
-        // target = CONVERT_VALUE_TO_VOLTAGE(cell_voltage_get_sum()) * INTERNAL_VOLTAGE_PRECHARGE_THRESHOLD;
+        // target = CONVERT_VALUE_TO_INTERNAL_VOLTAGE(internal_voltages.bat) * INTERNAL_VOLTAGE_PRECHARGE_THRESHOLD;
+        target = CONVERT_VALUE_TO_VOLTAGE(cell_voltage_get_sum()) * INTERNAL_VOLTAGE_PRECHARGE_THRESHOLD;
 
     return tsp >= target;
 }