Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for XQuery Tumbling and Sliding Window #4529

Open
wants to merge 74 commits into
base: develop
Choose a base branch
from
Open

Support for XQuery Tumbling and Sliding Window #4529

wants to merge 74 commits into from

Commits on Oct 29, 2023

  1. [test] Add Tumbling Window basic example

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    058c750 View commit details
    Browse the repository at this point in the history

  2. [feature] Add basic version of windowClause

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    818e2ff View commit details
    Browse the repository at this point in the history

  3. [feature] Add support for start condition for tumbling windowClause

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    b5b00fc View commit details
    Browse the repository at this point in the history

  4. [feature] Add support for windowEndCondition

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    3711e81 View commit details
    Browse the repository at this point in the history

  5. [feature] Add WindowExpr, WindowCondition to support WindowClause

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    6834883 View commit details
    Browse the repository at this point in the history

  6. [refactor] Improve parsing of Tumbling Window

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    cad39e4 View commit details
    Browse the repository at this point in the history

  7. [feature] Add handling of intermediate AST for Tumbling Window

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    d18e61d View commit details
    Browse the repository at this point in the history

  8. [test] Improve testing for Tumbling Window

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    c99ffea View commit details
    Browse the repository at this point in the history

  9. [feature] Add support for Sliding Window Expression

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    efb0e4e View commit details
    Browse the repository at this point in the history

  10. [test] Add test for Sliding Window Expression

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    fbbdbc4 View commit details
    Browse the repository at this point in the history

  11. [refactor] Rename to match XQuery spec

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    24fd165 View commit details
    Browse the repository at this point in the history

  12. [refactor] Mark nullable class members

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    4c50f49 View commit details
    Browse the repository at this point in the history

  13. [refactor] Reorder WindowCondition members to match XQuery spec

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    e2f8bdd View commit details
    Browse the repository at this point in the history

  14. [refactor] Variables used by Binding Expressions should be EQName acc… 

    …ording to the XQuery spec; these can be processed at parse time
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f54c973 View commit details
    Browse the repository at this point in the history

  15. [refactor] Move conflict check between for-expr binding variable name… 

    … and positional variable name into the parser
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    3bacea4 View commit details
    Browse the repository at this point in the history

  16. [refactor] Move conflict check between window binding variables names… 

    … into the parser
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    21078d5 View commit details
    Browse the repository at this point in the history

  17. [feature] Implement Sliding Window Expressions

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    5179316 View commit details
    Browse the repository at this point in the history

  18. [bugfix] Use the correct error code for a variable reference to an un… 

    …declared variable

Closes eXist-db#2060
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    d786e13 View commit details
    Browse the repository at this point in the history

  19. [bugfix] Ensure the correct scope of the Window variables

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    d545743 View commit details
    Browse the repository at this point in the history

  20. [bugfix] Fix bug in handling current item when positional var is present

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    4dae8c0 View commit details
    Browse the repository at this point in the history

  21. [test] Add more examples from reference

    @gabriele-tomassetti @adamretter
    gabriele-tomassetti authored and adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    a6bc38d View commit details
    Browse the repository at this point in the history

  22. [refactor] Remove need for starting eXist-db server from test

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    2dc9a2b View commit details
    Browse the repository at this point in the history

  23. [bugfix] Preserve the Error Code from the initial XQuery parser stage

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    87fedc4 View commit details
    Browse the repository at this point in the history

  24. [bugfix] Add missing ErrorCode on type checks

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    ec5415d View commit details
    Browse the repository at this point in the history

  25. [bugfix] Further type checks for Window Expr

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    3af0d4c View commit details
    Browse the repository at this point in the history

  26. [bugfix] 'declare variable' expressions should not remove the context… 

    … sequence
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f87e20b View commit details
    Browse the repository at this point in the history

  27. [bugfix] Correctly implement start-next-item and end-next-item for Wi… 

    …ndows
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    91ea433 View commit details
    Browse the repository at this point in the history

  28. [bugfix] Fix window type checks

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    8b079af View commit details
    Browse the repository at this point in the history

  29. [refactor] Simplify previous item handling

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    9be9ec2 View commit details
    Browse the repository at this point in the history

  30. [bugfix] Add missing error codes

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    506e94a View commit details
    Browse the repository at this point in the history

  31. [bugfix] Enable sorting of windows

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    62e4cd6 View commit details
    Browse the repository at this point in the history

  32. [bugfix] Correctly use start condition when end condition is absent

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    8d90fb8 View commit details
    Browse the repository at this point in the history

  33. [feature] Sliding Window support

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    dd83306 View commit details
    Browse the repository at this point in the history

  34. [bugfix] Fix use of group by in Windows

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    6dc74fc View commit details
    Browse the repository at this point in the history

  35. [bugfix] group by clause must atomize the group keys in the output tu… 

    …ple stream
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    eff6049 View commit details
    Browse the repository at this point in the history

  36. [bugfix] group by clause must adhere to type declarations on group va… 

    …riables
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    91b810d View commit details
    Browse the repository at this point in the history

  37. [bugfix] In the GroupingSpec of a Group By clause, the type declarati… 

    …on is not allowed if there is no ':= value' clause
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    1ca3cf1 View commit details
    Browse the repository at this point in the history

  38. [bugfix] Collator should be used when comparing node values in fn:dee… 

    …p-equal
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    ccde1c2 View commit details
    Browse the repository at this point in the history

  39. [refactor] Implement fn:deep-equal in terms of deepCompare (needed fo… 

    …r GroupByClause)
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    be6fede View commit details
    Browse the repository at this point in the history

  40. [optimise] Only evaluate arguments to fn:codepoint-equal once

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f50f1c7 View commit details
    Browse the repository at this point in the history

  41. [bugfix] Correctly implement op:same-key#2 for XQuery Map types

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    acf52bf View commit details
    Browse the repository at this point in the history

  42. [bugfix] Fix comparison of INF and -INF values for xs:float and xs:do… 

    …uble
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    9534cba View commit details
    Browse the repository at this point in the history

  43. [bugfix] Fix comparison of NaN values for xs:float and xs:double

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    f23615f View commit details
    Browse the repository at this point in the history

  44. [bugfix] Group By keys must be compared using fn:deep-equal when grou… 

    …ping
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    0167c37 View commit details
    Browse the repository at this point in the history

  45. [bugfix] Reimplement fn:sort so that it complies with the W3C specifi… 

    …cation. Now passes 100% of XQTS
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    ea94968 View commit details
    Browse the repository at this point in the history

  46. [bugfix] Group By must preserved the ordering of the tuple stream

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    29f5dde View commit details
    Browse the repository at this point in the history

  47. [bugfix] Group By Clause cannot group by variables that do not exist … 

    …in the pre-grouping tuple stream
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    69b07df View commit details
    Browse the repository at this point in the history

  48. [bugfix] DateTime values must consider timezone in Group By keys

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    ec7f1f1 View commit details
    Browse the repository at this point in the history

  49. [bugfix] Window expr must analyze the start and end window conditions

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    a86c93b View commit details
    Browse the repository at this point in the history

  50. [bugfix] Correct Sliding Window positional calculation

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    c855d8c View commit details
    Browse the repository at this point in the history

  51. [ignore] cleanup

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    acfa9ae View commit details
    Browse the repository at this point in the history

  52. [bugfix] Fix issues with reserved words for sliding and tumbling windows

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    b5618c0 View commit details
    Browse the repository at this point in the history

  53. [bugfix] Use correct error code when order by clause has more than on… 

    …e value (XQTS: prod-OrderByClause)
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    658d5a2 View commit details
    Browse the repository at this point in the history

  54. [bugfix] Use correct error code for unknown Collation (XQTS: prod-Ord… 

    …erByClause)
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    c901c47 View commit details
    Browse the repository at this point in the history

  55. [bugfix] Use correct Error Code when fn:exactly-one is called upon a … 

    …sequence (XQTS: prod-OrderByClause)
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    38cfc21 View commit details
    Browse the repository at this point in the history

  56. [bugfix] xs:hexBinary must support both upper and lower-case [a-f] ch… 

    …aracters (XQTS: prod-OrderByClause)
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    ed14b96 View commit details
    Browse the repository at this point in the history

  57. [bugfix] Further fixes to comparison of INF and -INF values for xs:fl… 

    …oat and xs:double (XQTS: prod-OrderByClause)
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    4d29903 View commit details
    Browse the repository at this point in the history

  58. [bugfix] Relative Collation URIs must be resolved relative to the bas… 

    …e-uri (XQTS: prod-OrderByClause)
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    2fd8324 View commit details
    Browse the repository at this point in the history

  59. [bugfix] Order By expression may need access to the Context Item (XQT… 

    …S: prod-OrderByClause)
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    4aed1a2 View commit details
    Browse the repository at this point in the history

  60. [refactor] Optimise for the positive path

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    46b115e View commit details
    Browse the repository at this point in the history

  61. [bugfix] Avoid an NPE when calling toString() after clear()

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    b3b5569 View commit details
    Browse the repository at this point in the history

  62. [bugfix] Fix toString representation of an OrderSpec

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    4889566 View commit details
    Browse the repository at this point in the history

  63. [optimise] Avoid unnecessary array allocation

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    886be90 View commit details
    Browse the repository at this point in the history

  64. [optimise] Reduce collection calls by using Deque functions

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    853dceb View commit details
    Browse the repository at this point in the history

  65. [optimise] Avoid over sizing the OrderedValueSequence

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    21819a8 View commit details
    Browse the repository at this point in the history

  66. [bugfix] Mixed primitive types must be coerced before Order By Clause… 

    … can be applied (XQTS: prod-OrderByClause)
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    58247f5 View commit details
    Browse the repository at this point in the history

  67. [bugfix] Return the correct error code from XQuery Functions that can… 

    …not find the indicated Collator
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    d4e7494 View commit details
    Browse the repository at this point in the history

  68. [bugfix] Need to bind the variables in the output tuple stream, now p… 

    …asses the test twt:jw-duplicate-words#0
    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    476410e View commit details
    Browse the repository at this point in the history

  69. [bugfix] Correct a bad test - groupby:atomize-group-vars#0

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    dbeeba4 View commit details
    Browse the repository at this point in the history

  70. [refactor] Address Codacy static analysis issues

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    7340308 View commit details
    Browse the repository at this point in the history

  71. [refactor] Address Code Review comments from @reinhapa

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    5e7b332 View commit details
    Browse the repository at this point in the history

  72. [refactor] Address SonarCloud static analysis issues

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    1c00798 View commit details
    Browse the repository at this point in the history

  73. [refactor] Address Code Review comments from @dizzzz

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    49d16e5 View commit details
    Browse the repository at this point in the history

  74. [refactor] Address further SonarCloud static analysis issues

    @adamretter
    adamretter committed Oct 29, 2023
    Configuration menu
    Copy the full SHA
    d118a3b View commit details
    Browse the repository at this point in the history