Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added documentation for content file pool #963

Merged
merged 2 commits into from Mar 18, 2024
Merged

Added documentation for content file pool #963

merged 2 commits into from Mar 18, 2024

Conversation

reinhapa
Copy link
Member

@reinhapa reinhapa commented Mar 14, 2024 •
edited by joewiz

Corresponds to eXist-db/exist#5195 and 6.x backport eXist-db/exist#5217.

@welcome Welcome
Copy link

welcome bot commented Mar 14, 2024

Thanks for opening this pull request! Please check out our contributing guidelines.

duncdrum
duncdrum approved these changes Mar 15, 2024
View reviewed changes
Copy link
Contributor

@duncdrum duncdrum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@joewiz
Copy link
Member

joewiz commented Mar 15, 2024

Should the allowed unit for the max-in-memory-size value be specified, or is this obvious to readers?

I notice that the word "HEAP" is capitalized here, whereas elsewhere in previous portions of the article it is not. Does this term need to be capitalized?

@reinhapa
Copy link
Member Author

Should the allowed unit for the max-in-memory-size value be specified, or is this obvious to readers?

Good point, I will try to address that...

I notice that the word "HEAP" is capitalized here, whereas elsewhere in previous portions of the article it is not. Does this term need to be capitalized?

Seems I missed that, I will change those accordingly...

@reinhapa
Copy link
Member Author

@joewiz could you check the documentation again?

@reinhapa reinhapa requested review from joewiz and removed request for line-o March 16, 2024 22:03
@joewiz
Copy link
Member

joewiz commented Mar 18, 2024

@reinhapa Looks great. Thank you!

@joewiz joewiz merged commit 2c928ad into eXist-db:master Mar 18, 2024
2 checks passed
@welcome Welcome
Copy link

welcome bot commented Mar 18, 2024

Congrats on your first merged pull request!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joewiz joewiz joewiz approved these changes

@duncdrum duncdrum duncdrum approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@reinhapa @joewiz @duncdrum