Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20820] Make security private #4792

Merged
merged 13 commits into from
May 29, 2024
Merged

[20820] Make security private #4792

merged 13 commits into from
May 29, 2024

Conversation

elianalf
Copy link
Contributor

@elianalf elianalf commented May 16, 2024 •
edited by EduPonz

Description

This pr makes security private, in particular:

  • logging
  • exception
  • cryptography
  • common
  • authentication
  • access control

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • N/A Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • ❌ Changes are backport compatible: they do NOT break ABI nor change library core behavior.
  • ❌ Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@elianalf elianalf added this to the v3.0.0 milestone May 16, 2024
@elianalf elianalf added the needs-review PR that is ready to be reviewed label May 20, 2024
JesusPoderoso

This comment was marked as resolved.

Sign in to view

@JesusPoderoso JesusPoderoso added to-do and removed needs-review PR that is ready to be reviewed labels May 21, 2024
@elianalf elianalf force-pushed the feature/make_security_private branch from e6960f2 to abf77b5 Compare May 23, 2024 06:11
@elianalf elianalf removed the to-do label May 23, 2024
@github-actions github-actions bot added ci-pending PR which CI is running labels May 23, 2024
JesusPoderoso

This comment was marked as outdated.

Sign in to view

@elianalf elianalf force-pushed the feature/make_security_private branch from 6f337ea to bea9309 Compare May 24, 2024 09:32
JesusPoderoso

This comment was marked as outdated.

Sign in to view

@JesusPoderoso JesusPoderoso added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 24, 2024
@github-actions github-actions bot added the ci-pending PR which CI is running label May 27, 2024
@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

@JesusPoderoso JesusPoderoso removed the ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. label May 27, 2024
JesusPoderoso
JesusPoderoso previously approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@JesusPoderoso JesusPoderoso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with green CI

@elianalf
Refs #20820: Make accesscontrol/AccessControl private
59d3116 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820: Make accesscontrol/EndpointSecurityAttributes private
67748ae 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820: Make accesscontrol/ParameterTypes private
047f830 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820: Make accesscontro/SecurityMaskUtilities private
32b0887 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820:Make authentication private
589fc54 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820: Make common private
c0db98f 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820: Make cryptography private
37144d6 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs 20820: Make exception private
f9eeec5 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820: Make logging private
d2d6456 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820: Apply suggestions and uncrustify
9f1889b 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820: Remove include ParticipantSecurityAttributes from public…
59aa27c 
… headers

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Move EndpointSecurityAttributes.h to /attributes and create EndpointS…
9aad94c 
…ecurityAttributes.cpp

Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf
Refs #20820: Uncrustify
212d70a 
Signed-off-by: elianalf <62831776+elianalf@users.noreply.github.com>
@elianalf elianalf force-pushed the feature/make_security_private branch from 3f469ea to 212d70a Compare May 28, 2024 07:53
@elianalf
Copy link
Contributor Author

@richiprosima please test_3 this

@EduPonz EduPonz added ready-to-merge Ready to be merged. CI and changes have been reviewed and approved. and removed ci-pending PR which CI is running labels May 29, 2024
@EduPonz EduPonz merged commit 12d4d86 into master May 29, 2024
11 of 15 checks passed
@EduPonz EduPonz deleted the feature/make_security_private branch May 29, 2024 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesusPoderoso JesusPoderoso Awaiting requested review from JesusPoderoso

Assignees
No one assigned
Labels
ready-to-merge Ready to be merged. CI and changes have been reviewed and approved.
Projects
None yet
Milestone
v3.0.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@elianalf @JesusPoderoso @EduPonz