[20903] DynamicData to JSON serializer #4780
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
Signed-off-by: Juan Lopez Fernandez <juanlopez@eprosima.com>
| } | ||
| else | ||
| { | ||
| EPROSIMA_LOG_WARNING(XTYPES_UTILS, "Error encountered while performing DynamicData to JSON serialization."); |
There was a problem hiding this comment.
Remove redundant warning or modify content so it's specific for this overload.
Comment on lines
+267
to
+281
| // Return loaned value | ||
| ReturnCode_t ret_return_loan; | ||
| if (RETCODE_OK != (ret_return_loan = data->return_loaned_value(st_data))) | ||
| { | ||
| EPROSIMA_LOG_WARNING(XTYPES_UTILS, "Error encountered while returning loaned value."); | ||
| } | ||
| // Give priority to prior error if occurred | ||
| if (RETCODE_OK != ret) | ||
| { | ||
| return ret; | ||
| } | ||
| else | ||
| { | ||
| return ret_return_loan; | ||
| } |
There was a problem hiding this comment.
Any nicer way of doing this?
|
|
||
| return json_serialize_member(data, type_member->get_id(), | ||
| traits<DynamicType>::narrow<DynamicTypeImpl>( | ||
| member_desc.type())->resolve_alias_enclosed_type()->get_kind(), |
There was a problem hiding this comment.
Extend DynamicTypeImpl to have a new attribute + getter for its enclosing type, so the recursive search is only done once.
13 tasks
|
Bitset inheritance has recently refactored, I would add coverage for this scenario. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces a couple of utility functions meant to ease the transformation of a
DynamicDatato a digestible JSON object, which is dumped either to a user-provided output string or ostream. The resulting JSON objects can follow the OMG standard format (as in https://www.omg.org/spec/DDS-JSON/1.0/Beta1/PDF), or an alternative custom one.Tests remain to be implemented.
Contributor Checklist
versions.mdfile (if applicable).Reviewer Checklist