Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20953] Support Type-Lookup Service with new new GUID-less Discovery Server #4768

Open
wants to merge 5 commits into
base: feature/mesh_ds_guid_less_3.0.x
Choose a base branch
from

Conversation

cferreiragonz
Copy link
Contributor

@cferreiragonz cferreiragonz commented May 10, 2024

Description

This PR modifies the behavior of TypeLookup service to ensure compatibility with the Discovery Server. Participants now issue the TypeLookupRequest to the participant that sent them the Data (r|w), rather than to the participant containing the endpoint. This adjustment allows servers to respond to their clients, thereby keeping discovery traffic limited to servers. Additionally, it addresses minor changes to improve functionality with the Discovery Server.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally: [20953] Support Type-Lookup Service with new new GUID-less Discovery Server Discovery-Server#78
  • N/A Any new/modified methods have been properly documented using Doxygen.
  • N/A Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • Changes are ABI compatible.
  • Changes are API compatible.
  • New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

…UID instead of proxy_data

Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
Signed-off-by: cferreiragonz <carlosferreira@eprosima.com>
@cferreiragonz cferreiragonz force-pushed the feature/ds_with_type_lookup_service branch from 68476c3 to 3774d59 Compare May 14, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-review PR that is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant