-
Notifications
You must be signed in to change notification settings - Fork 713
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20862] Improve ThreadSettingsQoS logging (backport #4744) #4755
Conversation
Cherry-pick of 7832901 has failed:
To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally |
* Refs #20862: Add BB tests Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20862: ThreadSettings logging improvements impl Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs #20862: Linter Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20862: Apply Miguel suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20862: Apply second rev Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20862: Applied third round suggestions Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> * Refs 20862: Remove old method in threading_empty Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> --------- Signed-off-by: Mario Dominguez <mariodominguez@eprosima.com> (cherry picked from commit 7832901)
cd4296c
to
44e093e
Compare
@richiprosima please test this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with green CI
CI issues are unrelated to the PR content |
Description
@Mergifyio backport 2.13.x
Contributor Checklist
Commit messages follow the project guidelines.
The code follows the style guidelines of this project.
Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
Any new/modified methods have been properly documented using Doxygen.
Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
Changes are ABI compatible.
Changes are API compatible.
N/A New feature has been added to the
versions.md
file (if applicable).N/A New feature has been documented/Current behavior is correctly described in the documentation.
Applicable backports have been included in the description.
Reviewer Checklist
This is an automatic backport of pull request #4744 done by [Mergify](https://mergify.com).