Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20853] Automatic TypeObject representation registration for DynamicTypes. #4746

Merged
merged 18 commits into from
May 20, 2024

Conversation

JLBuenoLopez
Copy link
Contributor

Description

This PR ensures that the TypeObject representation is automatically registered into the TypeObjectRegistry when the DynamicType is registered into the DomainParticipant.

Contributor Checklist

  • Commit messages follow the project guidelines.
  • The code follows the style guidelines of this project.
  • Tests that thoroughly check the new feature have been added/Regression tests checking the bug and its fix have been added; the added tests pass locally
  • Any new/modified methods have been properly documented using Doxygen.
  • NO Any new configuration API has an equivalent XML API (with the corresponding XSD extension)
  • N/A Changes are ABI compatible.
  • N/A Changes are API compatible.
  • N/A New feature has been added to the versions.md file (if applicable).
  • N/A New feature has been documented/Current behavior is correctly described in the documentation.
  • N/A Applicable backports have been included in the description.

Reviewer Checklist

  • The PR has a milestone assigned.
  • The title and description correctly express the PR's purpose.
  • Check contributor checklist is correct.
  • Check CI results: changes do not issue any warning.
  • Check CI results: failing tests are unrelated with the changes.

@richiware richiware force-pushed the feature/tests_for_dds_types_test branch 4 times, most recently from 29a0251 to f398436 Compare May 8, 2024 10:51
@richiware richiware force-pushed the feature/register_typeobject_w_dynamictype branch from c60b1ff to 56c4aeb Compare May 9, 2024 06:53
@EduPonz EduPonz added this to the v3.0.0 milestone May 10, 2024
@richiware richiware force-pushed the feature/register_typeobject_w_dynamictype branch from 56c4aeb to 4203db0 Compare May 10, 2024 10:52
@richiware richiware force-pushed the feature/tests_for_dds_types_test branch 5 times, most recently from 7801390 to be61920 Compare May 13, 2024 10:22
Base automatically changed from feature/tests_for_dds_types_test to master May 14, 2024 07:17
adriancampo and others added 15 commits May 14, 2024 09:23
…ort::register_type

Signed-off-by: adriancampo <adriancampo@eprosima.com>
…mplementation

Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: JLBuenoLopez-eProsima <joseluisbueno@eprosima.com>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware force-pushed the feature/register_typeobject_w_dynamictype branch from 4f72f5b to cff7da0 Compare May 14, 2024 07:55
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware self-requested a review May 16, 2024 10:46
@github-actions github-actions bot added the ci-pending PR which CI is running label May 16, 2024
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware requested review from richiware and removed request for richiware May 16, 2024 12:31
@richiware richiware force-pushed the feature/register_typeobject_w_dynamictype branch from 5774c88 to b68816a Compare May 17, 2024 09:47
@richiware richiware requested review from adriancampo and removed request for richiware and adriancampo May 17, 2024 09:47
@richiware richiware force-pushed the feature/register_typeobject_w_dynamictype branch from b68816a to de3c9ae Compare May 17, 2024 12:34
@richiware richiware self-requested a review May 17, 2024 12:34
Signed-off-by: Ricardo González Moreno <ricardo@richiware.dev>
@richiware richiware merged commit 82b01ca into master May 20, 2024
9 of 12 checks passed
@richiware richiware deleted the feature/register_typeobject_w_dynamictype branch May 20, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-pending PR which CI is running
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants