Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump nuraft to latest HEAD. #82

Merged
merged 2 commits into from
May 7, 2024
Merged

Bump nuraft to latest HEAD. #82

merged 2 commits into from
May 7, 2024

Conversation

szmyd
Copy link
Collaborator

@szmyd szmyd commented May 7, 2024 •
edited

@szmyd szmyd force-pushed the bump_nuraft branch 3 times, most recently from 234477e to 4339e0f Compare May 7, 2024 17:17
hkadayam
hkadayam previously approved these changes May 7, 2024
View reviewed changes
Copy link
Collaborator

@hkadayam hkadayam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, Thanks.

@hkadayam
Copy link
Collaborator

hkadayam commented May 7, 2024

Is it possible to update the conanfile version of nuraft_mesg as well, so we can track it easier?

@szmyd szmyd merged commit 53fbfbd into eBay:main May 7, 2024
12 checks passed
@szmyd szmyd deleted the bump_nuraft branch May 7, 2024 17:36
@raakella1 raakella1 mentioned this pull request May 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hkadayam hkadayam hkadayam left review comments

@raakella1 raakella1 Awaiting requested review from raakella1

@xiaoxichen xiaoxichen Awaiting requested review from xiaoxichen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@szmyd @hkadayam