Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make component and props' types optional in the standalone show function #151

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Make component and props' types optional in the standalone show function #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 5 additions & 4 deletions src/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -219,10 +219,11 @@ type NiceModalArgs<T> = T extends keyof JSX.IntrinsicElements | React.JSXElement
? React.ComponentProps<T>
: Record<string, unknown>;

export function show<T extends any, C extends any, P extends Partial<NiceModalArgs<React.FC<C>>>>(
modal: React.FC<C>,
args?: P,
): Promise<T>;
export function show<
T extends any,
C extends any = any,
P extends Partial<NiceModalArgs<React.FC<C>>> = Partial<NiceModalArgs<React.FC<C>>>,
>(modal: React.FC<C>, args?: P): Promise<T>;

export function show<T extends any>(modal: string, args?: Record<string, unknown>): Promise<T>;
export function show<T extends any, P extends any>(modal: string, args: P): Promise<T>;
Expand Down