Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(flag): moved flag from icon depdencies to flag #2169

Merged
merged 1 commit into from
May 7, 2024
Merged

Conversation

agliga
Copy link
Contributor

@agliga agliga commented May 6, 2024

Description

  • We are loading the flag CSS in icon, this was before the background icon changes. Because of this the CSS is extra large when using icons. So removed flags from icons styles

@agliga agliga requested review from ArtBlue and LuLaValva May 6, 2024 16:06
@agliga agliga self-assigned this May 6, 2024
Copy link

changeset-bot bot commented May 6, 2024

🦋 Changeset detected

Latest commit: 0cfc4dc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ebay/ebayui-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@ArtBlue ArtBlue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Is a similar change required in Skin?

@agliga
Copy link
Contributor Author

agliga commented May 7, 2024

Looks good. Is a similar change required in Skin?

Not needed. This is only for imports

@agliga agliga merged commit c49973f into master May 7, 2024
2 checks passed
@agliga agliga deleted the removed-flag branch May 7, 2024 16:21
@github-actions github-actions bot mentioned this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants