Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[#321] Upgrade React to v18 #336

Merged
merged 18 commits into from
Apr 26, 2024
Merged

[#321] Upgrade React to v18 #336

merged 18 commits into from
Apr 26, 2024

Conversation

darkwebdev
Copy link
Collaborator

@darkwebdev darkwebdev commented Apr 5, 2024 •
edited

  • React/ReactDOM + types v16 -> v18
  • improve event callbacks expectations (no more anySyntheticEvent)
  • replace toBeCalled/toBeCalledWith with toHaveBeenCalled/toHaveBeenCalledWith

Storybook

Published as @ebay/ui-core-react@6.2.2-rc.1

@darkwebdev
[#321] create folders in storybook, add more types in stories
62b9a0f
@darkwebdev
[#120] remove knobs from storybook
7ef1664
@darkwebdev
[#120] replace storyshots/snapshots with unit tests
4fba9e7
@darkwebdev
[#120] fix TS errors
30c906e
@darkwebdev
Merge branch 'main' into storybook-7
e3918a5 
# Conflicts:
#	.storybook/preview.js
#	src/ebay-alert-dialog/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-alert-dialog/__tests__/index.stories.tsx
#	src/ebay-breadcrumbs/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-breadcrumbs/__tests__/index.stories.tsx
#	src/ebay-button/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-button/__tests__/index.stories.tsx
#	src/ebay-calendar/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-calendar/__tests__/index.stories.tsx
#	src/ebay-carousel/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-carousel/__tests__/index.stories.tsx
#	src/ebay-checkbox/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-checkbox/__tests__/index.stories.tsx
#	src/ebay-confirm-dialog/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-confirm-dialog/__tests__/index.stories.tsx
#	src/ebay-cta-button/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-cta-button/__tests__/index.stories.tsx
#	src/ebay-date-textbox/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-date-textbox/__tests__/index.stories.tsx
#	src/ebay-drawer-dialog/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-drawer-dialog/__tests__/index.stories.tsx
#	src/ebay-eek/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-eek/__tests__/index.stories.tsx
#	src/ebay-fake-menu-button/__tests__/index.stories.tsx
#	src/ebay-fake-menu/__tests__/index.stories.tsx
#	src/ebay-fake-tabs/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-fake-tabs/__tests__/index.stories.tsx
#	src/ebay-field/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-field/__tests__/index.stories.tsx
#	src/ebay-fullscreen-dialog/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-fullscreen-dialog/__tests__/index.stories.tsx
#	src/ebay-icon-button/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-icon-button/__tests__/index.stories.tsx
#	src/ebay-icon/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-icon/__tests__/index.stories.tsx
#	src/ebay-infotip/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-infotip/__tests__/index.stories.tsx
#	src/ebay-inline-notice/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-inline-notice/__tests__/index.stories.tsx
#	src/ebay-lightbox-dialog/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-lightbox-dialog/__tests__/index.stories.tsx
#	src/ebay-listbox-button/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-menu-button/__tests__/index.stories.tsx
#	src/ebay-menu/__tests__/index.stories.tsx
#	src/ebay-page-notice/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-pagination/__tests__/index.stories.tsx
#	src/ebay-panel-dialog/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-panel-dialog/__tests__/index.stories.tsx
#	src/ebay-progress-bar/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-progress-bar/__tests__/index.stories.tsx
#	src/ebay-progress-spinner/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-progress-spinner/__tests__/index.stories.tsx
#	src/ebay-progress-stepper/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-progress-stepper/__tests__/index.stories.tsx
#	src/ebay-radio/__tests__/index.stories.tsx
#	src/ebay-section-notice/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-section-notice/__tests__/index.stories.tsx
#	src/ebay-section-title/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-section-title/__tests__/index.stories.tsx
#	src/ebay-select/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-select/__tests__/index.stories.tsx
#	src/ebay-signal/__tests__/index.stories.tsx
#	src/ebay-snackbar-dialog/__tests__/index.stories.tsx
#	src/ebay-split-button/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-split-button/__tests__/index.stories.tsx
#	src/ebay-star-rating-select/__tests__/index.stories.tsx
#	src/ebay-star-rating/__tests__/index.stories.tsx
#	src/ebay-switch/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-switch/__tests__/index.stories.tsx
#	src/ebay-tabs/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-tabs/__tests__/index.stories.tsx
#	src/ebay-textbox/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-textbox/__tests__/index.stories.tsx
#	src/ebay-toast-dialog/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-toast-dialog/__tests__/index.stories.tsx
#	src/ebay-tooltip/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-tourtip/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-video/__tests__/__snapshots__/index.spec.tsx.snap
#	src/ebay-video/__tests__/index.stories.tsx
#	yarn.lock
@darkwebdev
[#120] regenerate yarn.lock to fix errors
c2bfc05
@darkwebdev
[#120] fix lint/format errors
57136f9
@darkwebdev
[#120] add jest types
6a05b81
@darkwebdev
[#120] add workaround to avoid weird node error during build
7d416ce
@darkwebdev
[#120] fix storybook static build
36195d4
@darkwebdev
[#120] remove unused storybook-deployer
1688637
@darkwebdev
[#120] fix storybook static build script
86cba5b
@darkwebdev
[#240] Upgrade React to v18
4c9e4ef
@darkwebdev
Merge branch 'main' into react-18
062fcf4 
# Conflicts:
#	package.json
#	src/ebay-alert-dialog/__tests__/index.spec.tsx
#	src/ebay-breadcrumbs/__tests__/index.spec.tsx
#	src/ebay-button/__tests__/index.spec.tsx
#	src/ebay-calendar/__tests__/index.spec.tsx
#	src/ebay-calendar/__tests__/render.spec.tsx
#	src/ebay-checkbox/__tests__/index.spec.tsx
#	src/ebay-fake-menu-button/__tests__/index.spec.tsx
#	src/ebay-fake-menu/__tests__/index.spec.tsx
#	src/ebay-icon-button/__tests__/index.spec.tsx
#	src/ebay-listbox-button/__tests__/index.spec.tsx
#	src/ebay-page-notice/__tests__/index.spec.tsx
#	src/ebay-pagination/__tests__/index.spec.tsx
#	src/ebay-radio/__tests__/index.spec.tsx
#	src/ebay-section-notice/__tests__/index.spec.tsx
#	src/ebay-select/__tests__/index.spec.tsx
#	src/ebay-split-button/__tests__/index.spec.tsx
#	src/ebay-star-rating-select/__tests__/index.spec.tsx
#	src/ebay-switch/__tests__/index.spec.tsx
#	src/ebay-textbox/__tests__/index.spec.tsx
#	yarn.lock
@darkwebdev darkwebdev marked this pull request as ready for review April 5, 2024 14:39
HenriqueLimas
HenriqueLimas reviewed Apr 15, 2024
View reviewed changes
src/ebay-calendar/__tests__/render.spec.tsx Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@HenriqueLimas HenriqueLimas merged commit 30f18ec into main Apr 26, 2024
5 checks passed
@HenriqueLimas HenriqueLimas deleted the react-18 branch April 26, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HenriqueLimas HenriqueLimas HenriqueLimas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@darkwebdev @HenriqueLimas