[#285] strictNullChecks: true, fix 12 errors

eBay · Nov 16, 2023 · 80417b1 · 80417b1
1 parent 1163391
commit 80417b1
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 14 deletions.
diff --git a/src/ebay-video/__tests__/index.stories.tsx b/src/ebay-video/__tests__/index.stories.tsx
@@ -18,9 +18,9 @@ const defaultProps: EbayVideoProps = {
     errorText: "An error has occurred",
     width: 600,
     height: 400,
-    onPlay: (e: SyntheticEvent<HTMLVideoElement>, props: PlayEventProps) => action('onPlay')(e, props),
-    onVolumeChange: (e: SyntheticEvent<HTMLVideoElement>, props: VolumeChangeProps) => action('onVolumeChange')(e, props),
-    onLoadError: (err: Error) => action('onLoadError')(err),
+    onPlay: (e, props) => action('onPlay')(e, props),
+    onVolumeChange: (e, props) => action('onVolumeChange')(e, props),
+    onLoadError: (err) => action('onLoadError')(err),
     onReport: (e) => action('onReport')(e),
 }
 

diff --git a/src/ebay-video/video.tsx b/src/ebay-video/video.tsx
@@ -77,8 +77,8 @@ const EbayVideo: FC<EbayVideoProps> = ({
 
     const containerRef = useRef<HTMLDivElement>(null)
     const videoRef = useRef<HTMLVideoElement>(null)
-    const playerRef = useRef<Player>(null)
-    const uiRef = useRef(null)
+    const playerRef = useRef<Player | null>(null)
+    const uiRef = useRef<any>(null)
 
     const sources = filterByType(children, EbayVideoSource).map(elementProps)
 
@@ -143,7 +143,7 @@ const EbayVideo: FC<EbayVideoProps> = ({
             video,
             reportText
         )
-        uiRef.current.configure({
+        uiRef.current?.configure({
             addBigPlayButton: true,
             controlPanelElements: [],
             addSeekBar: false
@@ -166,10 +166,10 @@ const EbayVideo: FC<EbayVideoProps> = ({
     useEffect(() => {
         switch (action) {
             case 'play':
-                videoRef.current.play()
+                videoRef.current?.play()
                 break
             case 'pause':
-                videoRef.current.pause()
+                videoRef.current?.pause()
                 break
             default:
         }
@@ -186,7 +186,9 @@ const EbayVideo: FC<EbayVideoProps> = ({
             ...defaultVideoConfig,
             ...updatedControls
         })
-        videoRef.current.controls = false
+        if (videoRef.current) {
+            videoRef.current.controls = false
+        }
     }
 
     const handlePlaying = (e: SyntheticEvent<HTMLVideoElement, Event>) => {
@@ -195,15 +197,17 @@ const EbayVideo: FC<EbayVideoProps> = ({
         showControls()
 
         if (playView === 'fullscreen') {
-            videoRef.current.requestFullscreen()
+            videoRef.current?.requestFullscreen()
         }
 
         setPlaying(true)
-        onPlay(e, { player: playerRef.current })
+        if (playerRef.current) {
+            onPlay(e, { player: playerRef.current })
+        }
     }
 
     const handleOnPlayClick = () => {
-        videoRef.current.play()
+        videoRef.current?.play()
     }
 
     const handleVolumeChange = (e: SyntheticEvent<HTMLVideoElement, Event>) => {
@@ -217,7 +221,9 @@ const EbayVideo: FC<EbayVideoProps> = ({
     const handleOnPause = () => {
         // On IOS, the controls force showing up if the video exist fullscreen while playing.
         // This forces the controls to always hide
-        videoRef.current.controls = false
+        if (videoRef.current) {
+            videoRef.current.controls = false
+        }
     }
 
     const style = {

diff --git a/tsconfig.json b/tsconfig.json
@@ -17,7 +17,7 @@
         "strict": true,
         "strictBindCallApply": true,
         "strictFunctionTypes": true,
-        "strictNullChecks": false, // 150+ errors
+        "strictNullChecks": true,
         "strictPropertyInitialization": false,
         "useUnknownInCatchVariables": true,
         "noImplicitAny": false, // 300+ errors