Support build with Bazel #286
Conversation
| @@ -0,0 +1,32 @@ | |||
| -----BEGIN CERTIFICATE----- | |||
There was a problem hiding this comment.
We (eBay security dept) will not allow to include any certificate file in the public repo, even though it is just a dummy. Is it possible to add a script like this?
Lines 199 to 213 in cce3af7
README.md
Outdated
| Build with Bazel | ||
| ---------- | ||
| #### 1. Install Bazel | ||
| Follow [install instructions](https://docs.bazel.build/versions/5.0.0/install.html) |
There was a problem hiding this comment.
Because bazel is not backward compatible, we should tell the versions we support here.
examples/calculator/BUILD.bazel
Outdated
| @@ -0,0 +1,13 @@ | |||
| load("@rules_cc//cc:defs.bzl", "cc_binary") | |||
|
|
|||
There was a problem hiding this comment.
Is it possible to not add so many BUILD.bazel files?
There was a problem hiding this comment.
Yes, it's possible to combine some of them. But practice of bazel recommends "Every directory that contains buildable files should be a package.", https://docs.bazel.build/versions/main/best-practices.html#packages
Some empty BUILD file works as a flag(say {source-repository}/bazel/BUILD), it's required to keep them to make the build system happy.
| push: | ||
| branches: | ||
| - master | ||
| - bazel |
| pull_request: | ||
| branches: | ||
| - master | ||
| - bazel |
|
|
||
| - name: Setup Bazel | ||
| run: | | ||
| sudo apt-get -qq install npm |
There was a problem hiding this comment.
It's better to pin the bazel version.
|
As I mentioned above, please remove cert/key files and make them auto-generated. |
|
@greensky00 Got a few busy days and I would fix issues raised in the next commit. |
|
"This PR almost look good to me. But one concern is: do we have a better way to unify the cmake and bazel? otherwise they are hard to maintain." As a matter of fact, glob is used while defining nuraft artifact. It would be a rare case when there is a need to modify bazel script in the future. |
| @@ -0,0 +1,8 @@ | |||
| load("@rules_cc//cc:defs.bzl", "cc_library") | |||
There was a problem hiding this comment.
I'd like to move this file to bazel/thirdparty/asio.BUILD
|
Is there any update? |
|
@greensky00 If there is no more update, how about merging this PR and then we're refining it in the next PR? I'm looking forward this feature to integrate it to our repo in bazel building toolchain. |
|
Hi @jovany-wang |
Support build and run tests through Bazel so developers from Bazel community can reuse scripts, as is discussed in Issue 284