Fix device manager load of chunks. #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanebay
commented
Feb 13, 2024
sanebay
commented
Feb 13, 2024
sanebay
commented
Feb 13, 2024
sanebay
force-pushed
the
device_mgr_fix
branch
2 times, most recently
from
7fb6f47
to
9d2020c
Compare
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #321 +/- ##
==========================================
+ Coverage 49.84% 58.42% +8.58%
==========================================
Files 134 107 -27
Lines 14337 9333 -5004
Branches 1730 1202 -528
==========================================
- Hits 7146 5453 -1693
+ Misses 6547 3350 -3197
+ Partials 644 530 -114 ☔ View full report in Codecov by Sentry. |
yamingk
reviewed
Feb 13, 2024
yamingk
reviewed
Feb 13, 2024
sanebay
commented
Feb 13, 2024
sanebay
force-pushed
the
device_mgr_fix
branch
from
9d2020c
to
f1b04e9
Compare
hkadayam
reviewed
Feb 13, 2024
sanebay
force-pushed
the
device_mgr_fix
branch
2 times, most recently
from
dfc7a99
to
67c8422
Compare
sanebay
commented
Feb 14, 2024
sanebay
force-pushed
the
device_mgr_fix
branch
from
67c8422
to
a2ab285
Compare
hkadayam
reviewed
Feb 15, 2024
hkadayam
reviewed
Feb 15, 2024
hkadayam
reviewed
Feb 15, 2024
sanebay
force-pushed
the
device_mgr_fix
branch
2 times, most recently
from
de87714
to
35b11dc
Compare
hkadayam
previously approved these changes
Feb 16, 2024
sanebay
force-pushed
the
device_mgr_fix
branch
6 times, most recently
from
03cbe68
to
5e4e72d
Compare
sanebay
force-pushed
the
device_mgr_fix
branch
8 times, most recently
from
b443c0e
to
ccc85e8
Compare
sanebay
force-pushed
the
device_mgr_fix
branch
2 times, most recently
from
51cbf13
to
7bd7206
Compare
sanebay
commented
Mar 6, 2024
sanebay
force-pushed
the
device_mgr_fix
branch
5 times, most recently
from
68c86d7
to
8226a76
Compare
|
please update conan ver |
yamingk
reviewed
Mar 11, 2024
yamingk
reviewed
Mar 11, 2024
yamingk
reviewed
Mar 11, 2024
yamingk
reviewed
Mar 11, 2024
|
Reviewed the files under devices directory and thy look good to me, expect some cosmetic comments. |
yamingk
previously approved these changes
Mar 11, 2024
Chunks getting duplciate start offset while recovery. Add or cleanup logs for debugging. Add test case. Add more logdev for logstore test. Enable logstore test. Move rollback test to new logdev test.
Done. log_dev_test is using test_common::HSTestHelper::start_homestore |
yamingk
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chunks getting duplciate start offset while recovery. Add or cleanup logs for debugging. Add test case.