Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix#761 #763

Open
wants to merge 3 commits into
base: v5.5
Choose a base branch
from
Open

Fix#761 #763

wants to merge 3 commits into from

Conversation

KDGundermann
Copy link
Contributor

No description provided.

philipianpearce added a commit that referenced this pull request Mar 7, 2023
@philipianpearce
Comment out debug lines and tidy Logger code
3fefa54 
Based on pull request #763 by KDGundermann
philipianpearce
philipianpearce reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@philipianpearce philipianpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

HI,
It's something I had missed, thanks for code tidy which I have incorporated into the v5.5 branch.
Many thanks,
Philip

philipianpearce
philipianpearce reviewed Mar 8, 2023
View reviewed changes
Copy link
Contributor

@philipianpearce philipianpearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your re-arrangement of code logic in OptionContainer is, I think, a good idea. However, the logic changes are too big to deploy as a bug-fix in stable version and so I will look at incorporating in v5.6. I have deployed a simpler bug-fix for v5.5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philipianpearce philipianpearce philipianpearce left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@KDGundermann @philipianpearce