Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(#5131): Accurate resource open check when using log file handle #5134

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

Deltik
Copy link
Member

@Deltik Deltik commented Dec 4, 2023

Motivation and Context

Fixes: #5131

Description

Switch the logging file handle check to use is_resource() for correctly identifying whether the file handle is open.

How Has This Been Tested?

New unit test: e107EmailTest::testLogFileHandle()

Types of Changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist

@Deltik Deltik force-pushed the fix/5131 branch 2 times, most recently from 9dfe5fe to 688ebdf Compare December 4, 2023 03:29
Copy link

codeclimate bot commented Dec 4, 2023

Code Climate has analyzed commit 688ebdf and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (80% is the threshold).

This pull request will bring the total coverage in the repository to 38.7% (-0.1% change).

View more on Code Climate.

@CaMer0n CaMer0n merged commit 1ad7bc3 into e107inc:master Dec 4, 2023
23 of 24 checks passed
@CaMer0n
Copy link
Member

CaMer0n commented Dec 4, 2023

Great! Thank you @Deltik ! 👍

@Deltik Deltik deleted the fix/5131 branch December 4, 2023 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: white page after signup on e107.nl and after clicking on activating link in email
2 participants