Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s115 qemu command output #1145

Merged
merged 2 commits into from Apr 29, 2024
Merged

s115 qemu command output #1145

merged 2 commits into from Apr 29, 2024

Conversation

m-1-k-3
Copy link
Member

@m-1-k-3 m-1-k-3 commented Apr 29, 2024

  • What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

Feature

  • What is the current behavior? (You can also link to an open issue here)

requested multiple times. See also here https://infosec.exchange/@dizzyspiral/110882174812665098

  • What is the new behavior (if this is a feature change)? If possible add a screenshot.

image

@m-1-k-3 m-1-k-3 added enhancement New feature or request Core modules (Sxx) The core scanning modules (Sxx modules) EMBA labels Apr 29, 2024
@@ -675,6 +675,30 @@ emulate_binary() {
# This is very ugly and should only be used in docker environment!
pkill -9 -O "${QRUNTIME}" -f .*qemu-.*-sta.* >/dev/null || true
write_log "\\n-----------------------------------------------------------------\\n" "${LOG_FILE_BIN}"
write_log "\\n\\nFor reproducing the EMBA user-mode emulation mechanism, the following commands could be used as starting point:" "${LOG_FILE_BIN}"
write_log "\\n - Start EMBA docker container with the firmware directory as log directory:" "${LOG_FILE_BIN}"
local lFW_PATH=$(sort -u "${TMP_DIR}"/fw_name.log | head -1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shellcheck:
local lFW_PATH
lFW_PATH=$(sort -u "${TMP_DIR}"/fw_name.log | head -1)

if [[ -z "${CPU_CONFIG_}" ]] || [[ "${CPU_CONFIG_}" == "NONE" ]]; then
write_log "\\n - Start the emulation with the following command: " "${LOG_FILE_BIN}"
if [[ "${CHROOT}" == "jchroot" ]] || grep -q "jchroot" "${TMP_DIR}"/chroot_mode.tmp; then
write_log " # ${ORANGE}${CHROOT} ${OPTS[@]} . -- ./${EMULATOR} ${BIN_} <parameters like -v or --help>${NC}" "${LOG_FILE_BIN}"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe like this $*{OPTS[@]} ? I do not know if it is the intended solution

@HoxhaEndri HoxhaEndri merged commit 603dd33 into e-m-b-a:master Apr 29, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core modules (Sxx) The core scanning modules (Sxx modules) EMBA enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants