fix(filter-field): Fixes an issue where suggestions are not displayed in MS Edge #1625
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samuelfahrngruber
requested review from
lukasholzer and
thomaspink
as code owners
lukasholzer
previously approved these changes
Sep 16, 2020
There was a problem hiding this comment.
Awesome 🏄🏻♂️
Thank you very much for this contribution to help us improve the quality of our product! 💯
Please align with @thomaspink to fix the failing unit tests.
Run bazel run //libs/barista-components:test if you have followed the Bazel installation guide
… in MS Edge. When not using Ivy but View Engine, MS Edge did not display any suggestions. Closes dynatrace-oss#1558
lukasholzer
force-pushed
the
fix-filter-field-not-displaying-suggestions-in-ms-edge
branch
from
4a3f5a1
to
ed915de
Compare
lukasholzer
approved these changes
Sep 16, 2020
thomaspink
approved these changes
Sep 16, 2020
lukasholzer
added
pr: merge-ready
|
Manual cherry-picked into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
When not using Ivy but View Engine, MS Edge did not display any suggestions.
Closes #1558
Type of PR
Bugfix (non-breaking change which fixes an issue)
Checklist
Maybe running UI tests with
"angularCompilerOptions": { "enableIvy": false }could prevent problems with the old engine in the future.