-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
barista: Modifying isChild condition for avoiding opening wrong nodes #1351
barista: Modifying isChild condition for avoiding opening wrong nodes #1351
Conversation
Hi @PedroMosquera! Thank you for this contribution the code looks good. Would it make sense to add a test case for this, so we can make sure that this behaviour will not break in the future? |
Sure thing @tomheller, it totally makes sense. I'm working on those now 😄 |
@PedroMosquera please rebase with the latest master as there is a fix why build, stylelint and unit_test is failing |
60973f1
to
f7341fc
Compare
@lukasholzer I've just rebased master and those tasks are still failing. Not sure if I have to do something more |
f7341fc
to
3308198
Compare
Hi @PedroMosquera! |
Cherry pick done. |
Pull Request
Fixes #1245
The current sunburst uses IDs as a representation for each node. You can easy see the parent of every child by the base of their ID.
e.g.: node with ID
1.3.1
is the child of the node with1.3
.The current issue is that the application returns
true
when you ask if1.12.1
is the child of1.1
Type of PR
Bugfix (non-breaking change which fixes an issue)
Checklist