Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filter field] not displaying suggestions in MS Edge #1558

Closed
samuelfahrngruber opened this issue Sep 4, 2020 · 13 comments · Fixed by #1625
Closed

[Filter field] not displaying suggestions in MS Edge #1558

samuelfahrngruber opened this issue Sep 4, 2020 · 13 comments · Fixed by #1625
Labels
bug A broken behaviour that was working previously filter-field Temporary label for filter field issues has-pr

Comments

@samuelfahrngruber
Copy link
Contributor

samuelfahrngruber commented Sep 4, 2020

Bug Report

When clicking into the filter field in the non-chromium version of MS Edge, no filter suggestions are shown. Also, when typing, the clear all button does not appear. Instead there is a rather bad-looking "X" that clears the input (see screenshot).

This only happens, when the app is compiled with View Engine instead of Ivy though.

Expected Behavior

When clicking into the filter field, suggestions should be shown in a drop-down component, as in other browsers.

Current Behavior

Clicking into the filter field in MS Edge does not open a drop-down component with the filter suggestions. In place of the drop-down, a small border can be seen (see screenshot).

Steps to Reproduce

  1. Disable Angular Ivy in the app's tsconfig:
  "angularCompilerOptions": {
    "enableIvy": false
  }
  1. Click into the filter field in any non-chromium version MS Edge.
  2. No suggestion values are displayed

Context (Environment)

Used Versions:

  • angular: 10.0.9
  • @angular/cdk: 10.1.1
  • @dynatrace/barista-components: 8.0.0

Attachments

Strange X instead of "clear all"

image (5)

No dropdown but border visible

image (4)

Expected behaviour Firefox

image (7)

Actual behaviour MS Edge

image (6)

@samuelfahrngruber samuelfahrngruber added the bug A broken behaviour that was working previously label Sep 4, 2020
@samuelfahrngruber samuelfahrngruber changed the title Filter field not displaying suggestions in MS Edge Filter field does not displaying suggestions in MS Edge Sep 4, 2020
@samuelfahrngruber samuelfahrngruber changed the title Filter field does not displaying suggestions in MS Edge Filter field not displaying suggestions in MS Edge Sep 4, 2020
@samuelfahrngruber samuelfahrngruber changed the title Filter field not displaying suggestions in MS Edge [Filter field] not displaying suggestions in MS Edge Sep 7, 2020
@thomaspink thomaspink added the filter-field Temporary label for filter field issues label Sep 7, 2020
@lukasholzer
Copy link
Contributor

Did an investigation on Edge 16 on a Windows 10 Machine and no FilterField is displaying anything in the autocomplete:

image
image

@lukasholzer
Copy link
Contributor

@samuelfahrngruber your behaviour is not reproducible as in Edge Version 18 the autocomplete is displayed correctly.

@samuelfahrngruber
Copy link
Contributor Author

samuelfahrngruber commented Sep 8, 2020

@lukasholzer Are you using the samples on https://barista.dynatrace.com/? because they work fine for me in Edge 18 too.
However, the problem only occurs with the new version 8.0.0 of barista components, and the examples on https://barista.dynatrace.com/ do not use v8.0.0.

I am currently not able to build a local example with the filter field and barista 8.0.0, as i always get an error message when building a fresh project with only a filter field on the page:

ERROR in node_modules/@dynatrace/barista-components/button-group/src/button-group.d.ts:35:9 - error TS2611: 'disabled' is defined as a property in class 'HasTabIndex & DtButtonGroupBase', but is overridden here in 'DtButtonGroup<T>' as an accessor.
35     get disabled(): boolean;
           ~~~~~~~~
node_modules/@dynatrace/barista-components/button-group/src/button-group.d.ts:76:9 - error TS2611: 'disabled' is defined as a property in class 'HasTabIndex & CanColor<DtButtonGroupThemePalette> & DtButtonGroupItemBase', but is overridden here in 'DtButtonGroupItem<T>' as an accessor.
76     get disabled(): boolean;
           ~~~~~~~~

Should i file another bug for this issue?

Also, i can not provide a stackblitz example because it does not work at all with MS Edge.

EDIT: i created a bug for this problem #1577

@thomaspink
Copy link
Contributor

Seems to be an issue with dt-highlight on Edge.

The highlight component which is used inside every option for the autocomplete does not render the highlighted text.

It seems to be related to the 'IntersectionObserver` which is used in the highlight component. The observer does not fire on edge after the initial render when the overlay opens and the first options become visible.

All other browser work as intended.
The strange thing is that the IntersectionObserver is supported since Edge 15

@samuelfahrngruber
Copy link
Contributor Author

The issue occurrs after updating from version 7.5.1 to 8.0.0, previously we didn't have any problems.

@thomaspink
Copy link
Contributor

Currently checking if this is somehow related to issue #1420 (PR #1433) where this code area has been touched last.

@thomaspink
Copy link
Contributor

As it seems to be an IntersectionObserver bug for Edge <=16 I am currently thinking of disabling the highlighting for these browsers. This would make it at least useable.
Pls let me know your thoughts about this "solution".

@moertenschlag
Copy link
Contributor

Sounds reasonable for me - I vote for it.

@samuelfahrngruber
Copy link
Contributor Author

As it seems to be an IntersectionObserver bug for Edge <=16 I am currently thinking of disabling the highlighting for these browsers. This would make it at least useable.
Pls let me know your thoughts about this "solution".

Maybe also for other non-chromium Edge versions.
For me the problem also occurs with Edge 18.

Exact version:

Microsoft Edge 44.19041.423.0
Microsoft EdgeHTML 18.19041

@moertenschlag
Copy link
Contributor

Good point - same in my tests.

{browserName: MicrosoftEdge, browserVersion: 44.18362.449.0, javascriptEnabled: true, pageLoadStrategy: normal, platform: WINDOWS, platformName: WINDOWS, setWindowRect: false, timeouts: {implicit: 0, pageLoad: 300000, script: 30000}, , zal:screenResolution: 1600x1200, zal:tz: Europe/Vienna}

@lukasholzer
Copy link
Contributor

lukasholzer commented Sep 10, 2020

I'm Questioning why we have used it if we don't have the browser support for it. 🤔 AFAIK we have to support all Edge Versions or?
https://caniuse.com/intersectionobserver

@moertenschlag
Copy link
Contributor

@thomaspink any updates on this bug?

@samuelfahrngruber
Copy link
Contributor Author

samuelfahrngruber commented Sep 15, 2020

Having investigated further, the bug only occurs when the old View Engine is used instead of Ivy.
Reproducable by disabling Ivy

  "angularCompilerOptions": {
    "enableIvy": false
  }

and clicking into the filter field in MS Edge.

samuelfahrngruber added a commit to samuelfahrngruber/barista that referenced this issue Sep 15, 2020
… in MS Edge.

When not using Ivy but View Engine, MS Edge did not display any suggestions.

Closes dynatrace-oss#1558
lukasholzer pushed a commit to samuelfahrngruber/barista that referenced this issue Sep 16, 2020
… in MS Edge.

When not using Ivy but View Engine, MS Edge did not display any suggestions.

Closes dynatrace-oss#1558
lukasholzer pushed a commit that referenced this issue Sep 16, 2020
… in MS Edge.

When not using Ivy but View Engine, MS Edge did not display any suggestions.

Closes #1558
lukasholzer pushed a commit that referenced this issue Sep 16, 2020
… in MS Edge.

When not using Ivy but View Engine, MS Edge did not display any suggestions.

Closes #1558
lukasholzer pushed a commit that referenced this issue Sep 16, 2020
… in MS Edge.

When not using Ivy but View Engine, MS Edge did not display any suggestions.

Closes #1558
yngrdyn pushed a commit to yngrdyn/barista that referenced this issue Nov 9, 2020
… in MS Edge.

When not using Ivy but View Engine, MS Edge did not display any suggestions.

Closes dynatrace-oss#1558
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug A broken behaviour that was working previously filter-field Temporary label for filter field issues has-pr
Projects
None yet
4 participants