Add notebook review workflow #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpcurbelo
pushed a commit
to jpcurbelo/pysindy_fork
that referenced
this pull request
Apr 30, 2024
Add background notebook runner action.
Also:
Only build draft paper on pushes to master
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Twice per month, run all notebooks in the background. Part 1 of my response to #461. Part 2 will be a template repo that gets built as part of the pysindy docs lives outside of pysindy and has its own CI, as a venue for migration.
These tests will help us fix easy notebook issues in the interim and prioritize moving notebooks off of this repo.
I'm going to merge this now, because the last commit switched the notebook job to
on: schedule, which only runs on master, and can only be tested by merging.I also disabled the draft-pdf workflow for non-master branches. It still applies in PR, however. LMK if that's not desired.