Bug(stlsq): Fix #414, re-enabling UserWarning #466
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacob-Stevens-Haas
force-pushed
the
enable-warnings
branch
from
d399f66
to
97c5e9d
Compare
|
Apparently there were no deprecation warnings. I'm going to close this PR but leave the branch open for someone else since I labelled the issue as Good First Issue. Work to be done: Understand when warnings appear in tests and either fix them or silence them locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug became a big issue in the pytest 8.0 upgrade, as it caused us to miss deprecation warnings.