WIP: Functional constraints #18
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…and subsequent .ipynb
…niharika-krithika-mohammad-regionConstraints Updation
…//github.com/Jimmy-INL/pysensors into niharika-krithika-mohammad-regionConstraints
…ad-regionConstraints
… with radius constraints
…//github.com/niharika2999/pysensors into niharika-krithika-mohammad-regionConstraints
… updation for radius based constraints
…ctions which calculate and update the norm
…//github.com/niharika2999/pysensors into niharika-krithika-mohammad-regionConstraints
pysensors/utils/_constraints.py
Outdated
| ax.autoscale_view() | ||
|
|
||
|
|
||
| def constraint_function(self,x_all_unc, y_all_unc): |
There was a problem hiding this comment.
Still needs to be implemented.
pysensors/utils/_constraints.py
Outdated
| return idx_const,rank | ||
|
|
||
| def functional_constraints(functionHandler, idx,**kwargs): | ||
| """ |
There was a problem hiding this comment.
This should be split into two parts, one to get a function from a file, and one to use a function for a constraint.
There was a problem hiding this comment.
Has been changed based on our discussion
pysensors/utils/_constraints.py
Outdated
| if isinstance(info,tuple): | ||
| return np.unravel_index(idx,info,'F') | ||
| elif isinstance(info,pd.DataFrame): | ||
| x = info.loc[idx,'X (m)']#.values ## This will not always be X (m) or Y (m) CHANGE!!! |
There was a problem hiding this comment.
This hard coding of 'X (m)' and 'Y (m)' probably needs to be fixed.
There was a problem hiding this comment.
Has been changed to accept user input for 'X (m)' and 'Y (m)'
added 5 commits
September 28, 2023 12:34
…ons in _constraints based on discussions with Josh and Mohammad
…ser defined constraints and examples on how to implement it
…on to be greater than the optimal number suggested by plain QR and example notebook reflecting the same
I think we are sticking to 2-D data as of now but would like to introduce the handling of 3-D data in the future too. |
…w changes for the constraints class), addressing Josh's comments on this class and notebooks reflecting all of the functionalities of this class
… way user defined constraints are plotted for various string,equation implementations
…l as being able to plot on multiple axes for plot_constraints_on_data and subsequent plotting functions. Adding different colours to annotate_sensors and plotting_selected_sensors to reflect effect of constraints on sensors selected. Jupyter notebooks updated to reflect these changes
…tion as the matplotlib ellipse function requires the diameter or the vertical and horizontal axis and we were giving it half_major_axis and half_minor_axis)
…ction() of class Ellipse(), the functional_constraints_class notebook reflects these chnages
…onstraints_class' into functional_constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is unfinished and put here for commenting.