Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HuggingFace Refactor #154

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

HuggingFace Refactor #154

wants to merge 13 commits into from

Conversation

ludgerpaehler
Copy link
Collaborator

@jcallaham jcallaham self-requested a review March 15, 2024 06:09
Copy link
Collaborator

@jcallaham jcallaham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Could you maybe add an example or note in the docs about how users can pull this data? Maybe people will be familiar with HF repos, but at least I didn't know about them.

And let's actually keep the .geo files in the GH repo if that's okay with you. These are small and human readable, and it'd be nice to be able to see changes to mesh definitions easily. The other data is convenient but optional, since someone could rebuild it all themselves.

@ludgerpaehler
Copy link
Collaborator Author

ludgerpaehler commented Mar 15, 2024

Tasks to completion:

  • Move geometry files back in
  • Auto-call to the Huggingface-API doing away with the os-calls
  • Add respective subpage to the developer's documentation

@ludgerpaehler
Copy link
Collaborator Author

Great. Could you maybe add an example or note in the docs about how users can pull this data? Maybe people will be familiar with HF repos, but at least I didn't know about them.

The data-loading will be automatic, hidden away from the user.

@ludgerpaehler
Copy link
Collaborator Author

And let's actually keep the .geo files in the GH repo if that's okay with you.

I'd rather not. Leaving them out in the dataset repo allows us to purge the os-dependency, which we shouldn't have. I'd rather load them directly through the dataset API..

@ludgerpaehler
Copy link
Collaborator Author

Or we need to find a solution with the .geom files which does not involve os-calls. I see the utility of having them in the main tree to keep tabs, but we really shouldn't have os-calls. It is really bad practice and might easily fail users on clusters.

@ludgerpaehler
Copy link
Collaborator Author

ludgerpaehler commented Mar 15, 2024

@jcallaham same is valid for the default configurations btw, will try to move them out to their own json configurations later today s.t. they are isolated and we don't carry values in the configuration code anymore.

@ludgerpaehler
Copy link
Collaborator Author

WIP not merge-ready

@ludgerpaehler ludgerpaehler added enhancement New feature or request python Pull requests that update Python code labels Mar 16, 2024
@jcallaham
Copy link
Collaborator

Or we need to find a solution with the .geom files which does not involve os-calls. I see the utility of having them in the main tree to keep tabs, but we really shouldn't have os-calls. It is really bad practice and might easily fail users on clusters.

I'm good with that - when the built-in meshes can be pulled from HF we can get rid of the convenience of not having to specify the full path manually, which is all the os call does. Then we can move the .geo files to a meshes/ directory or something. But changes to the meshes need to be tracked in git, and there still needs to be a way of pointing to a local .msh file if you want to modify the geometry or create a custom environment. The HuggingFace repo should be a convenience but not a hard requirement.

Also if I wanted to rename the meshes away from the "coarse", "medium", "fine" towards something a little less misleading, is it too late to do that?

@ludgerpaehler ludgerpaehler self-assigned this Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request python Pull requests that update Python code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants