fix: upgrade cometbft

[faddat]

Description

This was originally a part of #677, but failed to integrate smoothly with dymension, so it's been broken out into its own PR so that it can be worked on separately from other version bumps.

---

Closes #XXX

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

• Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• Targeted PR against the correct branch
• included the correct type prefix in the PR title
• Linked to the GitHub issue with discussion and accepted design
• Targets only one GitHub issue
• Wrote unit and integration tests
• Wrote relevant migration scripts if necessary
• All CI checks have passed
• Added relevant godoc comments
• Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
• Add an issue in the e2e-tests repo if necessary

SDK Checklist

• Import/Export Genesis
• Registered Invariants
• Registered Events
• Updated openapi.yaml
• No usage of go map
• No usage of time.Now()
• Used fixed point arithmetic and not float arithmetic
• Avoid panicking in Begin/End block as much as possible
• No unexpected math Overflow
• Used sendCoin and not SendCoins
• Out-of-block compute is bounded
• No serialized ID at the end of store keys
• UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

• Confirmed the correct type prefix in the PR title
• Reviewers assigned
• Confirmed all author checklist items have been addressed

---;

After reviewer approval:

• In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
• In case the PR targets a release branch, PR must be rebased.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.53%. Comparing base (6cd9da4) to head (63108c3).
Report is 44 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main     #683   +/-   ##
=======================================
  Coverage   29.53%   29.53%           
=======================================
  Files         234      234           
  Lines       32672    32672           
=======================================
  Hits         9651     9651           
  Misses      21543    21543           
  Partials     1478     1478           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[omritoptix]

@faddat merge from main will prob fix linter issue

[faddat]

@omritoptix yep, it's all set now I think :)

[omritoptix]

@faddat can you please fix conflicts?

[danwt]

tests fail

[faddat]

@danwt you're referring to the e2e tests, correct?

I opened dymensionxyz/e2e-tests#65 to address :)

[danwt]

yes @faddat thanks!

[danwt]

Hey @faddat it looks like the tests only fail on this PR and not others, which points to a problem with the upgrades.

I tried to upgrade comet myself #722 and got some build error. How did you get around that?

[omritoptix]

@faddat as it's breaking the tests, unless there is a good reason to upgrade I think it's better to close this pr for now. going over the change-log didn't see anything critical. WDYT?

[faddat]

Basically the reason I'd promote this change is that there are ongoing fixes to cometbft. I can try to make a PR to the e2e test repo that would resolve this.

The issue is specifically with interchaintest, older versions of it aren't kept up to date:

https://github.com/strangelove-ventures/interchaintest/blob/v6/go.mod

so we encounter things like this.

The v0.34.x branch is no longer being actively maintained, so when there are new releases it's typically important.

Trouble is, the hack that I am aware of for fixing these build issues seems not to work.

• fix: dependency issues in v6 strangelove-ventures/interchaintest#1042

Once the PR above is merged, we will be able to use both the latest comet with fixes and interchaintest.

[faddat]

Here's a PR to the e2e tests:

• ensure that tests work with latest cometbft v0.34.x e2e-tests#75

[faddat]

~~I'm going to temporarily update this PR to use my fork repository statement, to demonstrate functionality. ~~

Since the image builds and stuff are tied to the dymensionxyz org, I think it will be much easier to just merge the above PR.

If:

• fix: dependency issues in v6 strangelove-ventures/interchaintest#1042

is merged then I'd recommend updating:

• ensure that tests work with latest cometbft v0.34.x e2e-tests#75

so that it is no longer using a replace statement.

[github-actions]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!

[github-actions]

This pull request has been automatically marked as stale because it has not had any recent activity. It will be closed if no further activity occurs. Thank you!