Don't link notifier thread #42
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows a callback to throw an exception without making the whole program crash. This is useful for the callback to prevent QoS1 and QoS2 messages from being acknowledged
albertov
force-pushed
the
dont_link_notifier
branch
from
7c29ddf
to
c6065f1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows a callback to throw an exception without making the whole program crash. This is useful for the callback to prevent QoS1 and QoS2 messages from being acknowledged.
This is a breaking change because now broken callbacks will fail silently, maybe some extra work is needed to, eg, log these errors?