Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README with Symfony set up hint #621

Merged
merged 2 commits into from Apr 29, 2024
Merged

Conversation

l0wskilled
Copy link
Sponsor Contributor

Added a clarification note to README.md to inform users how to set up a Symfony Flex application using the docker compose up --pull always -d --wait Docker command. This additional information provides clearer guidance for users looking to set up the application.

Added a clarification note to README.md to inform users how to set up a Symfony Flex application using the `docker compose up --pull always -d --wait` Docker command. This additional information provides clearer guidance for users looking to set up the application.
@l0wskilled
Copy link
Sponsor Contributor Author

Context is that I never expected that symfony gets set up via docker compose up. Another person didn't know it at first either. The README didn't make it clear that this step is automagically done.

README.md Outdated Show resolved Hide resolved
@dunglas
Copy link
Owner

dunglas commented Apr 27, 2024

I'm ok with @maxhelias' proposal. It's already written in the first line of the READMe and in the description that this is an "installer and runtime".

@l0wskilled
Copy link
Sponsor Contributor Author

It's @dunglas, im a big fan of your work.

Yes I read that but didn't realize that the docker command would set it up. I think this change if it is fine with you will improve the instructions for stupid people like me who tend to rush to the execution part.

@dunglas
Copy link
Owner

dunglas commented Apr 27, 2024

Thanks! Isn't rewording step 3 as suggested by Max good enough?

We try to keep the README as readable and as focused as possible.

@l0wskilled
Copy link
Sponsor Contributor Author

Yes, I will reword step 3 as he suggested and update the PR. I'm just currently not at home.

Rephrasing point 3 instead of using a note.
See: dunglas#621 (comment)
@l0wskilled
Copy link
Sponsor Contributor Author

Updated.

I got notice that it should be "set up", not a native.

Copy link
Owner

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

README.md Show resolved Hide resolved
@maxhelias maxhelias merged commit bfdd75e into dunglas:main Apr 29, 2024
2 checks passed
@maxhelias
Copy link
Collaborator

Thanks for this contribution 😃

@l0wskilled
Copy link
Sponsor Contributor Author

Thanks for this contribution 😃

Give a little bit take a little bit.
When there is stuff to improve with my abilities it's a no-brainer.

lbmolnar pushed a commit to lbmolnar/commission-calculator-demo that referenced this pull request May 7, 2024
Rephrasing point 3 instead of using a note.
See: dunglas/symfony-docker#621 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants