New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README with Symfony set up hint #621
Conversation
Added a clarification note to README.md to inform users how to set up a Symfony Flex application using the `docker compose up --pull always -d --wait` Docker command. This additional information provides clearer guidance for users looking to set up the application.
Context is that I never expected that symfony gets set up via |
I'm ok with @maxhelias' proposal. It's already written in the first line of the READMe and in the description that this is an "installer and runtime". |
It's @dunglas, im a big fan of your work. Yes I read that but didn't realize that the docker command would set it up. I think this change if it is fine with you will improve the instructions for stupid people like me who tend to rush to the execution part. |
Thanks! Isn't rewording step 3 as suggested by Max good enough? We try to keep the README as readable and as focused as possible. |
Yes, I will reword step 3 as he suggested and update the PR. I'm just currently not at home. |
Rephrasing point 3 instead of using a note. See: dunglas#621 (comment)
Updated. I got notice that it should be "set up", not a native. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thanks for this contribution 😃 |
Give a little bit take a little bit. |
Rephrasing point 3 instead of using a note. See: dunglas/symfony-docker#621 (comment)
Added a clarification note to README.md to inform users how to set up a Symfony Flex application using the
docker compose up --pull always -d --wait
Docker command. This additional information provides clearer guidance for users looking to set up the application.