Skip to content

Commit

Permalink
fix: volume instruction moved for all stages
Browse files Browse the repository at this point in the history
* /app/var shall be a volume on all stages to keep the overlay clean. Fixes #602

* Update Dockerfile

---------

Co-authored-by: Oliver Skibbe <oliver.skibbe@hdi.de>
Co-authored-by: Maxime Helias <maximehelias16@gmail.com>
  • Loading branch information
3 people committed Apr 22, 2024
1 parent e022f73 commit c7c788a
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion Dockerfile
Expand Up @@ -13,6 +13,8 @@ FROM frankenphp_upstream AS frankenphp_base

WORKDIR /app

VOLUME /app/var/

# persistent / runtime deps
# hadolint ignore=DL3008
RUN apt-get update && apt-get install -y --no-install-recommends \
Expand Down Expand Up @@ -50,7 +52,6 @@ CMD [ "frankenphp", "run", "--config", "/etc/caddy/Caddyfile" ]
FROM frankenphp_base AS frankenphp_dev

ENV APP_ENV=dev XDEBUG_MODE=off
VOLUME /app/var/

RUN mv "$PHP_INI_DIR/php.ini-development" "$PHP_INI_DIR/php.ini"

Expand Down

0 comments on commit c7c788a

Please sign in to comment.