This repository has been archived by the owner on Oct 15, 2022. It is now read-only.
bbc - using moment.js, removed unnecessary helpers #1910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Care to elaborate on that? Is it a bug in Moment.js? |
See here - moment/moment#348 So when the show duration is 3 hours 15 minutes, the |
|
@iambibhas can we do what was described in moment/moment#348 (comment)? I defined a modification to the language in a similar fashion for the Tor Node IA because of a similar problem. |
|
I guess its about as much code either way. This is fine for now 👍 |
moollaza
added a commit
that referenced
this pull request
Jun 15, 2015
bbc - using moment.js, removed unnecessary helpers
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saw this IA could use some moment.js love, so using that. Sadly can't remove the
duration()function as moment.js'humanize()function doesn't return accurate duration.