Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update tds endpoint and embedded tds #34

Merged
merged 1 commit into from
May 25, 2023
Merged

Update tds endpoint and embedded tds #34

merged 1 commit into from
May 25, 2023

Conversation

jaceklyp
Copy link
Contributor

Task/Issue URL: https://app.asana.com/0/1148434556963201/1204602434877143/f

Description:
Update tds endpoint and embedded tds

Steps to test this PR:

  1. Make sure tds is actually fetched from the endpoint.
  2. Smoke test if any tracking works.
Internal references:

Software Engineering Expectations
Technical Design Template

jotaemepereira
jotaemepereira approved these changes May 24, 2023
View reviewed changes
Copy link

@jotaemepereira jotaemepereira left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Installed this version and tested the described scenarios and other ones to make sure everything is working, and looks great 👍🏼

@jaceklyp jaceklyp merged commit 3ee219c into develop May 25, 2023
3 checks passed
@jaceklyp jaceklyp deleted the jacek/update-tds branch May 25, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jotaemepereira jotaemepereira jotaemepereira approved these changes

@bwaresiak bwaresiak Awaiting requested review from bwaresiak bwaresiak is a code owner

@brindy brindy Awaiting requested review from brindy brindy is a code owner

@tomasstrba tomasstrba Awaiting requested review from tomasstrba tomasstrba is a code owner

Assignees

@jaceklyp jaceklyp

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jaceklyp @jotaemepereira