Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix toolbar icon and fix a few warnings #31

Merged
merged 1 commit into from
Mar 24, 2023
Merged

Conversation

brindy
Copy link
Contributor

@brindy brindy commented Mar 18, 2023

Task/Issue URL: https://app.asana.com/0/1144193759412024/1204184574938009/f
Tech Design URL:
CC:

Description:

fix toolbar icon and fix a few warnings

Steps to test this PR:

  1. Install the Safari extension and enable it
  2. Ensure DDG icon shown next to address bar and in the "customise toolbar" view

Internal references:

Software Engineering Expectations
Technical Design Template

Copy link
Contributor

@jaceklyp jaceklyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brindy brindy merged commit e62c366 into develop Mar 24, 2023
@brindy brindy deleted the brindy/fix-toolbar-icon branch March 24, 2023 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants