Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mitigation for tomsguide freezing #971

Merged
merged 2 commits into from
May 30, 2023
Merged

Add mitigation for tomsguide freezing #971

merged 2 commits into from
May 30, 2023

Conversation

GuiltyDolphin
Copy link
Member

@GuiltyDolphin GuiltyDolphin requested review from a team, muodov and sammacbeth as code owners May 30, 2023 08:34
@github-actions
Copy link

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (13 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
--- v1/windows-config.json
+++ v1/windows-config.json
@@ -124,8 +124,12 @@
                     "domain": "t-online.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {
+                    "domain": "tomsguide.com",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
+                },
+                {
                     "domain": "welt.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {
latest
v2/android-config.json (13 more)
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
--- v2/windows-config.json
+++ v2/windows-config.json
@@ -124,8 +124,12 @@
                     "domain": "t-online.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {
+                    "domain": "tomsguide.com",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
+                },
+                {
                     "domain": "welt.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {

@GuiltyDolphin GuiltyDolphin added the merge when ready If you approve this PR, merge it immediately label May 30, 2023
@github-actions
Copy link

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (13 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
--- v1/windows-config.json
+++ v1/windows-config.json
@@ -124,8 +124,12 @@
                     "domain": "t-online.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {
+                    "domain": "tomsguide.com",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
+                },
+                {
                     "domain": "welt.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {
latest
v2/android-config.json (13 more)
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
--- v2/windows-config.json
+++ v2/windows-config.json
@@ -124,8 +124,12 @@
                     "domain": "t-online.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {
+                    "domain": "tomsguide.com",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
+                },
+                {
                     "domain": "welt.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {

@github-actions
Copy link

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (13 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
--- v1/windows-config.json
+++ v1/windows-config.json
@@ -124,8 +124,12 @@
                     "domain": "t-online.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {
+                    "domain": "tomsguide.com",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
+                },
+                {
                     "domain": "welt.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {
latest
v2/android-config.json (13 more)
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
--- v2/windows-config.json
+++ v2/windows-config.json
@@ -124,8 +124,12 @@
                     "domain": "t-online.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {
+                    "domain": "tomsguide.com",
+                    "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
+                },
+                {
                     "domain": "welt.de",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/326"
                 },
                 {

@SlayterDev SlayterDev merged commit a4d4466 into main May 30, 2023
3 checks passed
@SlayterDev SlayterDev deleted the gd-tomsguide branch May 30, 2023 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready If you approve this PR, merge it immediately
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants