Hide empty spaces on livestrong.com & genius.com + try experimental mitigation for wise.com #2083
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
laghee
requested review from
marcosholgado,
joshliebe,
aitorvs,
a team and
jonathanKingston
as code owners
|
Generated file outputs: legacyfingerprinting.json (3 more)
v1/android-config.json (2 more)
--- v3/android-config.json
+++ v3/android-config.json
@@ -4123,8 +4123,29 @@
}
]
},
{
+ "domain": "livestrong.com",
+ "rules": [
+ {
+ "selector": ".component-ar-horizontal-bar-ad",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".component-article-section-votd-container-outer",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".inline-ad",
+ "type": "hide"
+ },
+ {
+ "selector": ".component-header-sticky-ad",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "macrumors.com",
"rules": [
{
"selector": ".tertiary",
@@ -6376,8 +6397,12 @@
},
{
"domain": "withpersona.com",
"reason": "https://github.com/duckduckgo/privacy-configuration/issues/2008"
+ },
+ {
+ "domain": "wise.com",
+ "reason": "experimental mitigation for unreproduced issue as description corresponds to similar breakage"
}
],
"state": "enabled"
},
v1/extension-brave-config.json (38 more)
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -3298,8 +3298,29 @@
}
]
},
{
+ "domain": "livestrong.com",
+ "rules": [
+ {
+ "selector": ".component-ar-horizontal-bar-ad",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".component-article-section-votd-container-outer",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".inline-ad",
+ "type": "hide"
+ },
+ {
+ "selector": ".component-header-sticky-ad",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "macrumors.com",
"rules": [
{
"selector": ".tertiary",
latestv4/android-config.json--- v4/android-config.json
+++ v4/android-config.json
@@ -3818,8 +3818,29 @@
}
]
},
{
+ "domain": "livestrong.com",
+ "rules": [
+ {
+ "selector": ".component-ar-horizontal-bar-ad",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".component-article-section-votd-container-outer",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".inline-ad",
+ "type": "hide"
+ },
+ {
+ "selector": ".component-header-sticky-ad",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "macrumors.com",
"rules": [
{
"selector": ".tertiary",
@@ -5894,8 +5915,11 @@
"domain": "airbnb.si"
},
{
"domain": "withpersona.com"
+ },
+ {
+ "domain": "wise.com"
}
],
"state": "enabled"
},
v4/extension-brave-config.json (12 more)
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -3005,8 +3005,29 @@
}
]
},
{
+ "domain": "livestrong.com",
+ "rules": [
+ {
+ "selector": ".component-ar-horizontal-bar-ad",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".component-article-section-votd-container-outer",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".inline-ad",
+ "type": "hide"
+ },
+ {
+ "selector": ".component-header-sticky-ad",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "macrumors.com",
"rules": [
{
"selector": ".tertiary",
|
laghee
changed the title
|
Generated file outputs: legacyfingerprinting.json (3 more)
v1/android-config.json (2 more)
--- v3/android-config.json
+++ v3/android-config.json
@@ -3733,8 +3733,17 @@
}
]
},
{
+ "domain": "genius.com",
+ "rules": [
+ {
+ "selector": "[class^='DfpAd']",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "getpocket.com",
"rules": [
{
"selector": "[class*='syndication-ad']",
@@ -4123,8 +4132,29 @@
}
]
},
{
+ "domain": "livestrong.com",
+ "rules": [
+ {
+ "selector": ".component-ar-horizontal-bar-ad",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".component-article-section-votd-container-outer",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".inline-ad",
+ "type": "hide"
+ },
+ {
+ "selector": ".component-header-sticky-ad",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "macrumors.com",
"rules": [
{
"selector": ".tertiary",
@@ -6376,8 +6406,12 @@
},
{
"domain": "withpersona.com",
"reason": "https://github.com/duckduckgo/privacy-configuration/issues/2008"
+ },
+ {
+ "domain": "wise.com",
+ "reason": "experimental mitigation for unreproduced issue as description corresponds to similar breakage"
}
],
"state": "enabled"
},
v1/extension-brave-config.json (38 more)
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -2908,8 +2908,17 @@
}
]
},
{
+ "domain": "genius.com",
+ "rules": [
+ {
+ "selector": "[class^='DfpAd']",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "getpocket.com",
"rules": [
{
"selector": "[class*='syndication-ad']",
@@ -3298,8 +3307,29 @@
}
]
},
{
+ "domain": "livestrong.com",
+ "rules": [
+ {
+ "selector": ".component-ar-horizontal-bar-ad",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".component-article-section-votd-container-outer",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".inline-ad",
+ "type": "hide"
+ },
+ {
+ "selector": ".component-header-sticky-ad",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "macrumors.com",
"rules": [
{
"selector": ".tertiary",
latestv4/android-config.json--- v4/android-config.json
+++ v4/android-config.json
@@ -3428,8 +3428,17 @@
}
]
},
{
+ "domain": "genius.com",
+ "rules": [
+ {
+ "selector": "[class^='DfpAd']",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "getpocket.com",
"rules": [
{
"selector": "[class*='syndication-ad']",
@@ -3818,8 +3827,29 @@
}
]
},
{
+ "domain": "livestrong.com",
+ "rules": [
+ {
+ "selector": ".component-ar-horizontal-bar-ad",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".component-article-section-votd-container-outer",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".inline-ad",
+ "type": "hide"
+ },
+ {
+ "selector": ".component-header-sticky-ad",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "macrumors.com",
"rules": [
{
"selector": ".tertiary",
@@ -5894,8 +5924,11 @@
"domain": "airbnb.si"
},
{
"domain": "withpersona.com"
+ },
+ {
+ "domain": "wise.com"
}
],
"state": "enabled"
},
v4/extension-brave-config.json (12 more)
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -2615,8 +2615,17 @@
}
]
},
{
+ "domain": "genius.com",
+ "rules": [
+ {
+ "selector": "[class^='DfpAd']",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "getpocket.com",
"rules": [
{
"selector": "[class*='syndication-ad']",
@@ -3005,8 +3014,29 @@
}
]
},
{
+ "domain": "livestrong.com",
+ "rules": [
+ {
+ "selector": ".component-ar-horizontal-bar-ad",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".component-article-section-votd-container-outer",
+ "type": "hide-empty"
+ },
+ {
+ "selector": ".inline-ad",
+ "type": "hide"
+ },
+ {
+ "selector": ".component-header-sticky-ad",
+ "type": "hide"
+ }
+ ]
+ },
+ {
"domain": "macrumors.com",
"rules": [
{
"selector": ".tertiary",
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Asana Task/Github Issue:
https://app.asana.com/0/1200277586140538/1207327402088308/f
https://app.asana.com/0/1206670747178362/1207244160204381/f
https://app.asana.com/0/1206670747178362/1207328745672425/f
Description
Empty spaces on livestrong.com + genius.com, and reports of id verification failure for wise.com that sound similar to those on id.me and others for which we've already made exceptions.
Reference