Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow discount modal to be closed #2080

Merged
merged 1 commit into from
May 15, 2024
Merged

Conversation

laghee
Copy link
Contributor

@laghee laghee commented May 15, 2024

@laghee laghee requested review from a team as code owners May 15, 2024 18:34
Copy link

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (41 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -7194,8 +7194,19 @@
                                 "reason": "https://github.com/duckduckgo/privacy-configuration/issues/669"
                             }
                         ]
                     },
+                    "igodigital.com": {
+                        "rules": [
+                            {
+                                "rule": "collect.igodigital.com/collect.js",
+                                "domains": [
+                                    "goodwillfinds.com"
+                                ],
+                                "reason": "https://github.com/duckduckgo/privacy-configuration/issues/2079"
+                            }
+                        ]
+                    },
                     "iheart.com": {
                         "rules": [
                             {
                                 "rule": "iheart.com",
@@ -8846,8 +8857,19 @@
                                 "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1107"
                             }
                         ]
                     },
+                    "rbcroyalbank.com": {
+                        "rules": [
+                            {
+                                "rule": "collect.rbcroyalbank.com/collect.js",
+                                "domains": [
+                                    "goodwillfinds.com"
+                                ],
+                                "reason": "CNAME ENTRY GENERATED FROM: collect.igodigital.com"
+                            }
+                        ]
+                    },
                     "canadapost-postescanada.ca": {
                         "rules": [
                             {
                                 "rule": "evaluation.canadapost-postescanada.ca",
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -6624,8 +6624,18 @@
                                 ]
                             }
                         ]
                     },
+                    "igodigital.com": {
+                        "rules": [
+                            {
+                                "rule": "collect.igodigital.com/collect.js",
+                                "domains": [
+                                    "goodwillfinds.com"
+                                ]
+                            }
+                        ]
+                    },
                     "iheart.com": {
                         "rules": [
                             {
                                 "rule": "iheart.com",
@@ -8103,8 +8113,18 @@
                                 ]
                             }
                         ]
                     },
+                    "rbcroyalbank.com": {
+                        "rules": [
+                            {
+                                "rule": "collect.rbcroyalbank.com/collect.js",
+                                "domains": [
+                                    "goodwillfinds.com"
+                                ]
+                            }
+                        ]
+                    },
                     "canadapost-postescanada.ca": {
                         "rules": [
                             {
                                 "rule": "evaluation.canadapost-postescanada.ca",

@laghee laghee added the merge when ready If you approve this PR, merge it immediately label May 15, 2024
Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dharb dharb added this pull request to the merge queue May 15, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 15, 2024
@dharb dharb removed this pull request from the merge queue due to a manual request May 15, 2024
@dharb dharb added this pull request to the merge queue May 15, 2024
Merged via the queue into main with commit 914579f May 15, 2024
9 checks passed
@dharb dharb deleted the kate/mitigate-modal-goodwillfinds branch May 15, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready If you approve this PR, merge it immediately
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants