Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mitigate nationalmssociety.org payment section on macOS #1964

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

laghee
Copy link
Contributor

@laghee laghee commented Apr 3, 2024

@laghee laghee requested review from a team as code owners April 3, 2024 23:43
Copy link

github-actions bot commented Apr 3, 2024

Generated file outputs:

legacy
fingerprinting.json (42 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/windows-config.json
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/windows-config.json
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/windows-config.json

⚠️ File is identical

v1/macos-config.json (2 more)
  • v1/macos-config.json
  • v2/macos-config.json
  • v3/macos-config.json
--- v3/macos-config.json
+++ v3/macos-config.json
@@ -1419,8 +1419,12 @@
                     },
                     {
                         "domain": "sas.dk",
                         "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1347"
+                    },
+                    {
+                        "domain": "nationalmssociety.org",
+                        "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1963"
                     }
                 ]
             },
             "exceptions": [],
latest
v4/android-config.json (12 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/windows-config.json

⚠️ File is identical

v4/macos-config.json
--- v4/macos-config.json
+++ v4/macos-config.json
@@ -1124,8 +1124,12 @@
                     },
                     {
                         "domain": "sas.dk",
                         "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1347"
+                    },
+                    {
+                        "domain": "nationalmssociety.org",
+                        "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1963"
                     }
                 ]
             },
             "exceptions": [],

Copy link
Collaborator

@dharb dharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dharb dharb added this pull request to the merge queue Apr 3, 2024
Merged via the queue into main with commit 6a02fa5 Apr 3, 2024
9 checks passed
@dharb dharb deleted the kate/mitigate-nationalmssociety-payments branch April 3, 2024 23:51
dharb added a commit that referenced this pull request Apr 4, 2024
github-merge-queue bot pushed a commit that referenced this pull request Apr 4, 2024
* Update macos-override.json

* Update ios-override.json

* cherry pick rule from #1964

---------

Co-authored-by: David Harbage <dave@duckduckgo.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants