Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPM exception for hello-hossy.com #1939

Merged
merged 1 commit into from
Mar 28, 2024
Merged

Add CPM exception for hello-hossy.com #1939

merged 1 commit into from
Mar 28, 2024

Conversation

dharb
Copy link
Collaborator

@dharb dharb commented Mar 27, 2024

Asana Task/Github Issue: https://app.asana.com/0/1200277586140538/1206942144417509/f duckduckgo/autoconsent#406

Description

The cookie notice on this site isn't properly dismissed with CPM enabled.

Reference

@dharb dharb requested review from muodov, sammacbeth and a team as code owners March 27, 2024 22:12
@dharb dharb added the merge when ready If you approve this PR, merge it immediately label Mar 27, 2024
Copy link

Generated file outputs:

legacy
fingerprinting.json (3 more)
  • fingerprinting.json
  • protections.json
  • trackers-unprotected-temporary.txt
  • trackers-whitelist-temporary.txt

⚠️ File is identical

v1/android-config.json (41 more)
  • v1/android-config.json
  • v1/extension-brave-config.json
  • v1/extension-bravemv3-config.json
  • v1/extension-chrome-config.json
  • v1/extension-chromemv3-config.json
  • v1/extension-config.json
  • v1/extension-edg-config.json
  • v1/extension-edge-config.json
  • v1/extension-edgmv3-config.json
  • v1/extension-firefox-config.json
  • v1/extension-safarimv3-config.json
  • v1/ios-config.json
  • v1/macos-config.json
  • v1/windows-config.json
  • v2/android-config.json
  • v2/extension-brave-config.json
  • v2/extension-bravemv3-config.json
  • v2/extension-chrome-config.json
  • v2/extension-chromemv3-config.json
  • v2/extension-config.json
  • v2/extension-edg-config.json
  • v2/extension-edge-config.json
  • v2/extension-edgmv3-config.json
  • v2/extension-firefox-config.json
  • v2/extension-safarimv3-config.json
  • v2/ios-config.json
  • v2/macos-config.json
  • v2/windows-config.json
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/ios-config.json
  • v3/macos-config.json
  • v3/windows-config.json
--- v3/windows-config.json
+++ v3/windows-config.json
@@ -324,8 +324,12 @@
                     "domain": "www.ffbb.com",
                     "reason": "https://github.com/duckduckgo/autoconsent/issues/401"
                 },
                 {
+                    "domain": "hello-hossy.com",
+                    "reason": "https://github.com/duckduckgo/autoconsent/issues/406"
+                },
+                {
                     "domain": "earth.google.com",
                     "reason": "https://github.com/duckduckgo/privacy-configuration/issues/1099"
                 },
                 {
latest
v4/android-config.json (13 more)
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/ios-config.json
  • v4/macos-config.json
  • v4/windows-config.json
--- v4/windows-config.json
+++ v4/windows-config.json
@@ -266,8 +266,11 @@
                 {
                     "domain": "www.ffbb.com"
                 },
                 {
+                    "domain": "hello-hossy.com"
+                },
+                {
                     "domain": "earth.google.com"
                 },
                 {
                     "domain": "iscorp.com"

@sammacbeth sammacbeth added this pull request to the merge queue Mar 28, 2024
Merged via the queue into main with commit fbb3940 Mar 28, 2024
11 checks passed
@sammacbeth sammacbeth deleted the dharb/cpm-hh branch March 28, 2024 07:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merge when ready If you approve this PR, merge it immediately
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants