Remove VPN waitlist code #2795
Remove VPN waitlist code #2795
Conversation
| @@ -179,7 +175,6 @@ struct RemoteMessaging { | |||
| favoritesCount: favoritesCount, | |||
| appTheme: AppUserDefaults().currentThemeName.rawValue, | |||
| isWidgetInstalled: isWidgetInstalled, | |||
| isNetPWaitlistUser: isNetworkProtectionWaitlistUser, | |||
| daysSinceNetPEnabled: daysSinceNetworkProtectionEnabled), | |||
There was a problem hiding this comment.
Do I need to remove this too, @samsymons ?
There was a problem hiding this comment.
Let's keep these since they'll be used for RMF attribute matching on Privacy Pro subscribers
There was a problem hiding this comment.
I want to make sure I understand correctly here.
I was asking about daysSinceNetPEnabled but now I wonder if your answer includes isNetPWaitlistUser too.
There was a problem hiding this comment.
No, we no longer need isNetPWaitlistUser, it's just daysSinceNetPEnabled that will be needed going forward.
| @@ -91,7 +76,7 @@ struct NetworkProtectionAccessController: NetworkProtectionAccess { | |||
| } | |||
|
|
|||
| // Check for users who have activated the VPN via an invite code: | |||
| if networkProtectionActivation.isFeatureActivated && !networkProtectionWaitlistStorage.isInvited { | |||
| if networkProtectionActivation.isFeatureActivated { | |||
| return .inviteCodeInvited | |||
There was a problem hiding this comment.
Do we still need this? cc @samsymons
There was a problem hiding this comment.
Nah, this can be removed.
There was a problem hiding this comment.
@samsymons - Should I remove the entire file? I was about to remove it but decided to ask in case there's a plan to add PPro support here.
There was a problem hiding this comment.
If we're managing access elsewhere this can be removed, sure. Access control is super simple now thanks to PPro.
|
This PR has been inactive for more than 7 days and will be automatically closed 7 days from now. |
Task/Issue URL: https://app.asana.com/0/414235014887631/1207178910368620/f
macOS: https://github.com/duckduckgo/macos-browser/pull/2776
BSK: duckduckgo/BrowserServicesKit#801
Description
Let's remove the VPN waitlist code from iOS.
Testing
Internal references:
Software Engineering Expectations
Technical Design Template