Remove ATB from default params #2430

samsymons · 2024-02-04T23:40:51Z

Task/Issue URL: https://app.asana.com/0/414235014887631/1206435379975124/f
Tech Design URL:
CC:

Description:

This PR updates the Pixel and DailyPixel fire functions to change the default parameters.

Steps to test this PR:

Check that appLaunch is always including ATB
Check that pixels from VPN exit criteria include ATB
Check that no pixels called out on the Help Needed thread have been missed
Check that all other pixels are excluding ATB by default

Device Testing:

OS Testing:

iOS 14
iOS 15
iOS 16

Internal references:

Software Engineering Expectations
Technical Design Template

* main: (41 commits) Update BSK with autofill 10.1.0 (#2414) Bump submodules/privacy-reference-tests from `a3acc21` to `6b7ad1e` (#2408) Add Autoconsent onByDefault subfeature (#2423) Metadata reverted https://app.asana.com/0/0/1206476969305202/1206481077004998/f metadata updated Release 7.107.0-0 (#2421) More script fixes (#2419) More release script fixes (#2418) Release/7.106.0-4 (#2417) Reenable toggle on disallowing vpn (#2404) (#2416) Don't crash when AppRatingPromptEntity fetch errors (#2388) Add error codes to site breakage reports (#2413) Don't set dryRun for alpha builds (#2412) Add VPN redemption retry event (#2409) Changes to hotfix process (#2406) Release/7.106.0-3 changes (#2411) Fix tab loading (#2410) Improve waitlist invite code checks (#2398) Reenable toggle on disallowing vpn (#2404) Bump BrowserServicesKit to 103.0.2 (#2393) ...

github-actions · 2024-04-14T00:18:52Z

This PR has been inactive for more than 7 days and will be automatically closed 7 days from now.

# By Daniel Bernal (33) and others # Via Mariusz Śpiewak (5) and others * main: (245 commits) Fix inconsistent bars state when scrolling (#2733) fix tests (#2732) Release 7.115.0-4 (#2729) Fix VPN denial prompt loop (#2728) Small UI Fixes for subscriptions (#2690) SPM updated: SwiftSoup, Lottie, ZIPFoundation (#2724) Release 7.115.0-3 (#2727) VPN: Specific TunnelController start failure reporting (#2714) update bsk dependency (#2725) Subscriptions: Fix thread issue on Subscription Restore (#2719) Manage ‘Stale’ PRs (#2723) maestro: hide dax dialogs if visible and cancel keyboard after fireproof (#2695) Remove timezone offset from the VPN server object (#2701) Reverting accidental push to main (#2718) Add SubscriptionContainerViewModel and Manually hide loader + Pixel (#2687) Release 7.115.0-2 (#2712) soft revert history suggestions (#2711) Bring back accessibility identifiers for onboarding buttons (#2709) BSK release 133.1.0 (#2708) ... # Conflicts: # Core/Pixel.swift

* main: Release 7.116.0-1 (#2761) Remove validator app (#2754) Fix crash when quickly adding/removing tabs in switcher (#2760) Fix settings navigation bar colors after reopening (#2758) Alpha ad-hoc lane (#2492) Keep a weak reference to UserScriptMessageBroker (#2755) Add refresh config cell to top of debug (#2735) VPN: Replace available interfaces in VPN metadata (#2750) Require device auth to be set in order to use Sync (#2722) Add new iOS pixels for measuring navigation (#2730) Privacy pro metadata updates (#2747) Update autoconsent to v10.6.1 (#2734) Limit Stale actions to issues (#2745) Change DAU pixel for VPN to weekly (#2684) Support Autofill Domains with Port Number Suffixes (#2715) Update secure vault error pixels to fire daily (#2557) Subscription: Fix 'Back' button not present (#2741) Subscription State improvements + Remove SUBSCRIPTION Flag (#2726) Release 7.116.0-0 (#2739) Release 7.116.0-0 (#2737)

PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift

quanganhdo · 2024-04-18T14:11:41Z

Also missing: networkProtectionEnableAttemptConnecting, networkProtectionEnableAttemptSuccess, networkProtectionEnableAttemptFailure. I've added those.

* main: (38 commits) Disable the feedback send button when there’s no text (#2800) Release 7.118.0-0 (#2802) Autofill Settings - Import passwords via sync (#2756) Fix selected VPN location consistency (#2797) Reapply "Report Apple Ad attribution using pixel" (#2702) reapply auto clear fix, clear cookies, load page on link click (#2798) Toggle Connect on Demand when receiving user initiated VPN lifecycle events (#2771) Update BSK to 141.1.1 (#2796) iOS: VPN Metadata Improvements (#2791) Add Internal Page suggestions support (#2784) iOS: Add pixels to track VPN wake and stop attempts (#2785) Fix bug that shows selected tab in strange position in the switcher (#2789) Remove AppTP (#2682) Release 7.117.0-1 (#2794) cherry pick progress bar fix (#2793) fix progress bar missing after cold launch (#2792) Check entitlements before showing VPN screen from notification (#2748) Add parameter allowed encoding to error descriptions (#2781) Update Lottie to 4.4.3 (#2765) Update to fastlane 2.220.0 to fix ad-hoc lane (#2782) ...

samsymons · 2024-04-30T05:34:51Z

Core/UniquePixel.swift

@@ -52,14 +52,15 @@ public final class UniquePixel {
    /// This requires the pixel name to end with `_u`
    public static func fire(pixel: Pixel.Event,
                            withAdditionalParameters params: [String: String] = [:],
+                            includedParameters: [Pixel.QueryParameters] = [.appVersion],


Added this to the UniquePixel API so that the caller can control the parameters, before this it was relying on the default parameters.

samsymons · 2024-04-30T05:35:12Z

DuckDuckGo/AdAttribution/AdAttributionPixelReporter.swift

+                    try await pixelFiring.fire(
+                        pixel: .appleAdAttribution,
+                        withAdditionalParameters: parameters,
+                        includedParameters: [.appVersion, .atb]
+                    )


The attribution feature requires ATB, so I've added it and updated its tests. cc @dus7.

bwaresiak

LGTM!

* main: Fix Kingfisher deprecation warnings (#2799) VPN server failure detection recovery (#2779)

Changes are already resolved

* main: Release 7.118.0-1 (#2812) [Release PR] Update VPN metadata reporter (#2808) fix address bar weirdness (#2810) Fix RMF button styling for "big_two_action" format (#2811) Existing experiment disabled, the new Settings experiment activated (#2801) Create Asana Subtask on PR requested (#2803) Remove ATB from default params (#2430) Fix Kingfisher deprecation warnings (#2799) VPN server failure detection recovery (#2779) Disable the feedback send button when there’s no text (#2800)

# By Sam Symons (3) and others # Via Chris Brind (1) and GitHub (1) * main: Release 7.118.0-1 (#2812) [Release PR] Update VPN metadata reporter (#2808) fix address bar weirdness (#2810) Fix RMF button styling for "big_two_action" format (#2811) Existing experiment disabled, the new Settings experiment activated (#2801) Create Asana Subtask on PR requested (#2803) Remove ATB from default params (#2430) Fix Kingfisher deprecation warnings (#2799) VPN server failure detection recovery (#2779) # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved

samsymons added 3 commits January 24, 2024 15:04

Remove ATB from the default included parameter arrays.

64f72de

Remove ATB from DailyPixel by default.

f1ac813

samsymons requested a review from bwaresiak February 4, 2024 23:40

samsymons changed the title ~~Sam/remove atb from default pixel parameters~~ Remove ATB from default params Feb 4, 2024

github-actions bot added the stale label Apr 14, 2024

samsymons added 5 commits April 14, 2024 18:58

Remove ATB from default pixel API.

07b1187

Update ATB usage for the VPN.

bad2a3c

Add ATB to app launch.

73491e3

samsymons removed the stale label Apr 18, 2024

samsymons requested a review from quanganhdo April 18, 2024 02:44

quanganhdo previously requested changes Apr 18, 2024

View reviewed changes

PacketTunnelProvider/NetworkProtection/NetworkProtectionPacketTunnelProvider.swift Outdated Show resolved Hide resolved

Add ATB to other NetP exit criteria pixels

be9eb8f

github-actions bot added stale and removed stale labels Apr 27, 2024

samsymons added 2 commits April 29, 2024 22:10

Add ATB to the attribution reporter.

196db3c

duckduckgo deleted a comment from github-actions bot Apr 30, 2024

samsymons commented Apr 30, 2024

View reviewed changes

duckduckgo deleted a comment from Home1730 Apr 30, 2024

bwaresiak approved these changes Apr 30, 2024

View reviewed changes

Merge branch 'main' into sam/remove-atb-from-default-pixel-parameters

e3ca4d3

* main: Fix Kingfisher deprecation warnings (#2799) VPN server failure detection recovery (#2779)

samsymons requested a review from quanganhdo April 30, 2024 19:59

samsymons merged commit 022fd60 into main Apr 30, 2024
13 checks passed

samsymons deleted the sam/remove-atb-from-default-pixel-parameters branch April 30, 2024 20:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove ATB from default params #2430

Remove ATB from default params #2430

samsymons commented Feb 4, 2024 •

edited

github-actions bot commented Apr 14, 2024

quanganhdo commented Apr 18, 2024 •

edited

samsymons Apr 30, 2024

samsymons Apr 30, 2024

bwaresiak left a comment

Remove ATB from default params #2430

Remove ATB from default params #2430

Conversation

samsymons commented Feb 4, 2024 • edited

Internal references:

github-actions bot commented Apr 14, 2024

quanganhdo commented Apr 18, 2024 • edited

samsymons Apr 30, 2024

Choose a reason for hiding this comment

samsymons Apr 30, 2024

Choose a reason for hiding this comment

bwaresiak left a comment

Choose a reason for hiding this comment

samsymons commented Feb 4, 2024 •

edited

quanganhdo commented Apr 18, 2024 •

edited