Skip to content

Commit

Permalink
Revert "Disable local proxying for adclick attribution tests (#2285)"
Browse files Browse the repository at this point in the history
This reverts commit 09b27eb.
  • Loading branch information
sammacbeth committed Nov 20, 2023
1 parent 97d634d commit c18cdf3
Show file tree
Hide file tree
Showing 2 changed files with 9 additions and 1 deletion.
3 changes: 3 additions & 0 deletions integration-test/click-attribution.spec.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
import { test, expect } from './helpers/playwrightHarness'
import backgroundWait from './helpers/backgroundWait'
import testCases from 'privacy-test-pages/adClickFlow/shared/testCases.json'
import { routeFromLocalhost } from './helpers/testPages'

if (testCases.length === 0) {
throw new Error('No test cases found')
Expand Down Expand Up @@ -50,6 +51,8 @@ test.describe('Ad click blocking', () => {
// Allow to filter to one test case
const itMethod = testCase.only ? test.only : test
itMethod(testCase.name, async ({ context }) => {
// route requests from all pages in this test to our local test server
await routeFromLocalhost(context)
let page = await context.newPage()
for (const step of testCase.steps) {
if (step.action.type === 'navigate') {
Expand Down
7 changes: 6 additions & 1 deletion integration-test/helpers/testPages.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,12 @@ const testPageHosts = new Set([
'privacy-test-pages.site',
'broken.third-party.site',
'good.third-party.site',
'bad.third-party.site'
'bad.third-party.site',
'convert.ad-company.site',
// 'www.search-company.site',
// 'www.ad-company.site', - redirects to these domains via route overriding seem to hang, so this one has to hit the real server
'www.publisher-company.site',
'www.payment-company.site'
])

export const TEST_SERVER_ORIGIN = 'http://127.0.0.1:3000'
Expand Down

0 comments on commit c18cdf3

Please sign in to comment.