unify special page messaging #957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. Join @shakyShane and the rest of your teammates on |
shakyShane
commented
May 6, 2024
This was referenced May 6, 2024
Draft
shakyShane
commented
May 9, 2024
There was a problem hiding this comment.
@greyivy in the spirit of merging often and early, could you review this first PR, which is just a small refactoring to set us up nicely for the NTP
shakyShane
force-pushed
the
05-06-unify_special_page_messaging
branch
from
a4bcf56
to
030c441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1201614831475344/1207244302971195/f
TL;DR
Updated messaging setup in special pages to use a shared
createSpecialPageMessagingfunction.What changed?
How to test?
Why make this change?
Centralized messaging setup for consistency and reusability