don't default to addtional properties in schemas #952
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://app.asana.com/0/1201614831475344/1207053312757015/f
TL;DR
This PR restricts additional properties in the build-types script.
What changed?
The
createTypesForSchemaFile
andcreateTypesForSchemaMessages
functions inbuild-types.mjs
now include theadditionalProperties: false
option.Why make this change?
The library that generates the types makes open-ended objects by default by adding the index signature.
without this change, it's really tedious to create schemas since every top-level and nested object requires you to put
"additonalProperties": false