only accept first 11 chars of video id

[shakyShane]

https://app.asana.com/0/0/1206957893781164/f

TL;DR

Modified validation and sanitization of video IDs in the duck-player module.

What changed?

1. The validateVideoId function now checks first if the input is a string. If not, it returns null. If the input is a string, the function extracts the first 11 characters, validates them against a regex pattern and returns these characters if they pass the validation.
2. The function getValidVideoId now potentially returns null instead of false.

How to test?

The testing responsibilities have been accounted for in the duckplayer.spec.js file. A test has been added that checks whether the ID validation correctly accepts only the first 11 characters of a video ID.

Why make this change?

This change was required to improve the validation of video IDs, considering only the necessary characters and properly handling different data types. It also paves the way for more robust error handling by returning null instead of false in certain functions.

---

[shakyShane]

• IGNORE - temp assets for ship-review #947
• only accept first 11 chars of video id #951 👈
• main

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite

[shakyShane]

@jonathanKingston I renamed that method.