Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(duck-player): autofocus video on page load #946

Merged
merged 3 commits into from
Apr 9, 2024
Merged

fix(duck-player): autofocus video on page load #946

merged 3 commits into from
Apr 9, 2024

Conversation

shakyShane
Copy link
Collaborator

@shakyShane shakyShane commented Apr 2, 2024 •
edited

https://app.asana.com/0/0/1206957893781160/f

Testing Steps

  • npm run build in the root of this project
  • run the macOS application with this repo as a local dependency
  • follow the steps in the Asana task

@shakyShane
Copy link
Collaborator Author

shakyShane commented Apr 2, 2024 •
edited

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @shakyShane and the rest of your teammates on Graphite Graphite

@shakyShane shakyShane changed the title test: added an example test case for video autofocus fix(duck-player): autofocus video on page load Apr 2, 2024
@shakyShane shakyShane marked this pull request as ready for review April 2, 2024 11:45
@shakyShane shakyShane force-pushed the 04-02-test_added_an_example_test_case_for_video_autofocus branch from 79aaa6c to 3de6883 Compare April 2, 2024 12:18
@shakyShane shakyShane mentioned this pull request Apr 2, 2024
Draft
@shakyShane shakyShane assigned sjbarag and unassigned sjbarag Apr 8, 2024
GioSensation
GioSensation approved these changes Apr 9, 2024
View reviewed changes
Copy link
Member

@GioSensation GioSensation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't run it in browsers, but changes look good. I see Omid has already tested extensively, so we're good.

@shakyShane shakyShane merged commit ca904a0 into main Apr 9, 2024
4 checks passed
@shakyShane shakyShane deleted the 04-02-test_added_an_example_test_case_for_video_autofocus branch April 9, 2024 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GioSensation GioSensation GioSensation approved these changes

@jonathanKingston jonathanKingston Awaiting requested review from jonathanKingston jonathanKingston is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@shakyShane @GioSensation @sjbarag