-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DBP: adding other actions #844
Conversation
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
@muodov this adds all the other actions, the next PR has all the tests. Please let me know if you'd like me to break this down further, I'd be happy to do so if it's easier to review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM, no blockers, but a few questions/comments.
70d90ca
to
73257fc
Compare
@jonathanKingston @muodov - I've added a few extra commits to address the feedback, thanks! I think we'll ready to merge this, and then it's onto the integration tests :) |
@shakyShane (Adding this from mobile, so apologies if I’m not seeing this change and for the late comment). We spoke on Asana about adding playwright as a top level dependency, can we do that in this PR? |
@brianhall we can do that in the next one, which is 100% playwright tests :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, just one remark about url encoding. Thanks for the changes!
Thanks! merging now since we have approvals from @brianhall and @muodov, I also addressed feedback from @jonathanKingston |
https://app.asana.com/0/0/1206000767975136/f
Feature Summary
Native platforms will send one of the following instructions, one at a time:
navigate
extract
click
<- already added in a previous PRexpectation
fillForm
getCaptchaInfo
solveCaptcha
Each of them has a corresponding function that will be executed, and will return either a SuccessResponse or ErrorResponse to native.
The flow looks like this: (taken from the markdown file in the PR)